Created
February 15, 2010 21:24
-
-
Save andyferra/305011 to your computer and use it in GitHub Desktop.
chat with dkubb about dm-validations :email_format
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conekt: question... can you think of a case where 'user@something' without a .com would be a valid email? | |
conekt: or a .anything... | |
dkubb: some internal email systems would accept it, but for it to be routed internet you would need a valid tld | |
conekt: apparently :format => :email_address allows that... | |
dkubb: a valid tld being a gTLD, ccTLD or arpa | |
conekt: agreed, but if my intention is to validate user input in a web application, that feels like bad input just waiting to happen | |
dkubb: hmm, that is probably a bug. can you submit a ticket with that problem? | |
conekt: sure, I agree with the current implementation in principal... maybe if :email_address only matched web friendly examples and there was another built in pattern that would matching those other cases that would blow up on the web | |
conekt: for the issue, you want the whole example file with specs and everything I assume? | |
dkubb: the email address regexp matches emails according to the RFC's, except the RFC's are more generic than what an internet email address looks like. IMHO we should match internet email addresses | |
dkubb: reduced specs are always a bonus. it bumps the tickets most to the front of the queue | |
conekt: agreed, and then we can have a :rfc_compliant_email_address format or something :) | |
conekt: :pedantic_email_format :) | |
dkubb: I would probably defer that too until it's asked for. I would guess 99.9% of the people using it want internet email addresses to be the default | |
conekt: wholly agreed | |
conekt: cool, I'll post that at some point today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment