Skip to content

Instantly share code, notes, and snippets.

Created September 28, 2010 19:56
Show Gist options
  • Save anonymous/601665 to your computer and use it in GitHub Desktop.
Save anonymous/601665 to your computer and use it in GitHub Desktop.
diff --git a/src/game/Group.cpp b/src/game/Group.cpp
index a138674..c142af1 100644
--- a/src/game/Group.cpp
+++ b/src/game/Group.cpp
@@ -1028,11 +1028,12 @@ void Group::SendUpdate()
data << uint8(m_groupType); // group type (flags in 3.3)
data << uint8(citr->group); // groupid
data << uint8(GetFlags(*citr)); // group flags
- data << uint8(isBGGroup() ? 1 : 0); // 2.0.x, isBattleGroundGroup?
+ // 2.0.x, isBattleGroundGroup? and 3.3.x - if m_groupType & GROUPTYPE_LFD then current player role
+ data << uint8(isBGGroup() ? 1 : 0);
if(m_groupType & GROUPTYPE_LFD)
{
- data << uint8(0);
- data << uint32(0);
+ data << uint8(0); // Instance status
+ data << uint32(0); // Dungeon entry
}
data << uint64(0x50000000FFFFFFFELL); // related to voice chat?
data << uint32(0); // 3.3, this value increments every time SMSG_GROUP_LIST is sent
@@ -1050,7 +1051,7 @@ void Group::SendUpdate()
data << uint8(onlineState); // online-state
data << uint8(citr2->group); // groupid
data << uint8(GetFlags(*citr2)); // group flags
- data << uint8(0); // 3.3, role?
+ data << uint8(0); // LFD group role
}
data << m_leaderGuid; // leader guid
diff --git a/src/game/Group.h b/src/game/Group.h
index 45a949a..4ff1d3c 100644
--- a/src/game/Group.h
+++ b/src/game/Group.h
@@ -98,8 +98,12 @@ enum GroupType // group type flags?
GROUPTYPE_BG = 0x01,
GROUPTYPE_RAID = 0x02,
GROUPTYPE_BGRAID = GROUPTYPE_BG | GROUPTYPE_RAID, // mask
- // 0x04?
- GROUPTYPE_LFD = 0x08,
+ // will show vote kick option, dungeon guide instead of leader
+ GROUPTYPE_RANDOM = 0x04,
+ // will show LFG icon at minimap, roles at party portrait, possibly only this one for premade lfg group
+ GROUPTYPE_LFD = 0x08,
+ // mask, party with only random players have this (checked 3.3.x), not sure about premade
+ GROUPTYPE_RNDLFD = GROUPTYPE_RANDOM | GROUPTYPE_LFD;
// 0x10, leave/change group?, I saw this flag when leaving group and after leaving BG while in group
};
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment