Created
December 31, 2012 19:06
-
-
Save ehsan/4422031 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diff --git a/content/html/content/test/reflect.js b/content/html/content/test/reflect.js | |
index 5da6712..24c7bec 100644 | |
--- a/content/html/content/test/reflect.js | |
+++ b/content/html/content/test/reflect.js | |
@@ -43,17 +43,6 @@ function reflectString(aParameters) | |
is(element[idlAttr], "", | |
"When not set, the IDL attribute should return the empty string"); | |
- /** | |
- * TODO: as long as null stringification doesn't follow the WebIDL | |
- * specifications, don't add it to the loop below and keep it here. | |
- */ | |
- element.setAttribute(contentAttr, null); | |
- is(element.getAttribute(contentAttr), "null", | |
- "null should have been stringified to 'null'"); | |
- is(element[idlAttr], "null", | |
- "null should have been stringified to 'null'"); | |
- element.removeAttribute(contentAttr); | |
- | |
element[idlAttr] = null; | |
// TODO: remove this ugly hack when null stringification will work as expected. | |
if (element.localName == "textarea" && idlAttr == "wrap") { | |
@@ -61,12 +50,6 @@ function reflectString(aParameters) | |
"null should have been stringified to 'null'"); | |
is(element[idlAttr], "null", "null should have been stringified to 'null'"); | |
element.removeAttribute(contentAttr); | |
- } else { | |
- todo_is(element.getAttribute(contentAttr), "null", | |
- "null should have been stringified to 'null'"); | |
- todo_is(element[idlAttr], "null", | |
- "null should have been stringified to 'null'"); | |
- element.removeAttribute(contentAttr); | |
} | |
// Tests various strings. | |
@@ -78,8 +61,7 @@ function reflectString(aParameters) | |
[ "foo", "foo" ], | |
[ contentAttr, contentAttr ], | |
[ idlAttr, idlAttr ], | |
- // TODO: uncomment this when null stringification will follow the specs. | |
- // [ null, "null" ], | |
+ [ null, "null" ], | |
[ undefined, "undefined" ], | |
[ true, "true" ], | |
[ false, "false" ], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment