Skip to content

Instantly share code, notes, and snippets.

@Hans5958
Created April 15, 2020 14:11
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
Star You must be signed in to star a gist
Save Hans5958/ce9ac983895a7b0f1b18cba6b1c08fea to your computer and use it in GitHub Desktop.

Suggestions

  1. Add a settings menu.

There is a settings menu

Oh, whoops. I probably I said that because that menu is too simple for a settings menu.

  1. Add an option to disable the graphics on the menu. A simple color background is prefered.

If by graphics you mean the fire, there is a shortcut for it listed. ctrl-E

No, I mean those wavy backgrounds on the main menu.

  1. Add an option to set custom frame rate and dimensions.

Currently you can set both of those by resizing the window and changing your frame rate in the settings

I mean it is quite limited, y'know.

  1. Add an option to turn off motion blur.

There is no motion blur

Huh really weird. That might be YouTube's fault with it's compression.

  1. Intergrate OM using KDMAPI? https://github.com/KeppySoftware/OmniMIDI/tree/master/DeveloperContent/KDMAPI.md

I'll work on this at some point. For the moment I'm focused on general stability and polish rather than optimizations for black midi.

Well, it's not generally about Black MIDI, because OM is a MIDI driver, which can be used as a substitue than having a DAW with a loopMIDI in it, but I see why you say it is related to Black MIDI due to the fact that it is known for that.

I see.

  1. Accurate timers, please.

Timers? If you mean the ETA on Render, it calculates the remaining time based on the time it took to get that far already. If you have a better formula for that please do let me know.

I'm not keen on C++, but I think you should not use the FPS for the first few frames to calculate the time left. Calculate it for each frame, and probably average it if possible. This assumes that you refer it to the system clock, and not the engine clock.

  1. Add an option to use the normal GUI for selecting MIDIs instead of the rendered dialog.

Normal GUI? If you mean the Windows file explorer, please keep in mind that we plan to be platform-agnostic, meaning that we are trying to get Embers to work on as many platforms as possible.

I see. Interesting approach. probably use the OS file picker for each OS

Bugs and Comments

  1. Ask the others to use other that MSGSWS, please. (For you, public readers, don't use MSGSWS and use something like OmniMIDI or VMS)

People can use what they want. MSGSWS is easy for people to use and requires no set up. There's something to be had there.

Right. I understand.

  1. ue4 for a midi player is a overkill

Ok

no seriously

  1. Nice work, and congrats for the launch.

Thanks!

np

Addendum 1

  1. Add a FPS counter.
  2. Should I do some of the suggestion on the GitHub issues?
  3. Probably add more customization to the effects and particles.
  4. gib me fre 128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment