Skip to content

Instantly share code, notes, and snippets.

View MartinKei's full-sized avatar

Martin Keiblinger MartinKei

  • Kognitiv Gmbh
  • Vienna
View GitHub Profile
@MartinKei
MartinKei / 2nd review.md
Last active May 9, 2017 07:39
Short summary of 2nd review

Second Code-Review

Almost all issues are gone now. Except the usage of any in the channel service nothing serious is left. The channel service looks like as if it was overlooked. The other services look just fine.

any usage where types would make sense

  • channel.service.ts

Usage of inner functions