Skip to content

Instantly share code, notes, and snippets.

View MiguelCastillo's full-sized avatar

Miguel Castillo MiguelCastillo

View GitHub Profile

Code Reviews: A Controversial Policy

How I Will Perform Code Reviews
  • We Code Review after each story, and I use them as a place to have discussions where we have the opportunity to learn from one another.

  • I trust the other developers on my team, especially since they will have more context on their own work, so anything I suggest is merely a suggestion, and so I always "Approve" my github review. I give them the benefit of the doubt that if I point out something, it is more than likely I misunderstood.

  • It is entirely reasonable for people to use their discretion to disagree with or defer my suggestions for improvement.

@ebidel
ebidel / feature_detect_es_modules.js
Last active September 4, 2023 13:56
Feature detect ES modules: both static import and dynamic import()
<!--
Complete feature detection for ES modules. Covers:
1. Static import: import * from './foo.js';
2. Dynamic import(): import('./foo.js').then(module => {...});
Demo: http://jsbin.com/tilisaledu/1/edit?html,output
Thanks to @_gsathya, @kevincennis, @rauschma, @malyw for the help.
-->