Skip to content

Instantly share code, notes, and snippets.

@MrCrambo

MrCrambo/ETH_McAfeeDex_report.md Secret

Created October 20, 2019 21:56
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save MrCrambo/f5b5c3f6fb934bd944202e917d7e5561 to your computer and use it in GitHub Desktop.
Save MrCrambo/f5b5c3f6fb934bd944202e917d7e5561 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
ETH_McAfeeDex_report.md

Summary

This is the report from a security audit performed on McAfeeDex by MrCrambo.

The audit focused primarily on the security of McAfeeDex smart contracts.

In scope

  1. https://github.com/Mshuu/MCAFEEDEXCONTRACT/blob/master/contract.sol

Findings

In total, 3 issues were reported including:

  • 0 high severity issues.

  • 3 medium severity issues.

  • 0 owner privilegies issues.

  • 0 low severity issues.

Security issues

1. Transfer and Transfer from functions issue

Severity: medium

Description

Functions transfer and transferFrom should throw instead of returning false in case of wrong conditions.

2. Destroying any address tokens

Severity: medium

Description

Minter can destroy any address tokens without any restritcions.

Recommendation

Add checking for allowance before destroying any addess tokens.

3. Anyone can set account level

Severity: medium

Description

Anyone can call function setAccountLevel and can set highest level to any account.

Conclusion

Smart contract contains medium severity issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment