-
-
Save SDiamante13/4fec8b4ac2568ee935b0e42ef77925be to your computer and use it in GitHub Desktop.
Simplify if else. isLeapYear is now very readable and is at a single level of abstraction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| package tech.pathtoprogramming.tdd; | |
| import org.junit.jupiter.params.ParameterizedTest; | |
| import org.junit.jupiter.params.provider.CsvSource; | |
| import static org.assertj.core.api.Assertions.assertThat; | |
| class AYearShould { | |
| @ParameterizedTest | |
| @CsvSource({ | |
| "2001,false", | |
| "1996,true", | |
| "1992,true", | |
| "1900,false", | |
| "2000,true" | |
| }) | |
| void determineWhetherAGivenYearIsALeapYearOrNot(int givenYear, boolean isExpectedLeapYear) { | |
| boolean isLeapYear = new Year(givenYear).isLeapYear(); | |
| assertThat(isLeapYear).isEqualTo(isExpectedLeapYear); | |
| } | |
| } | |
| class Year { | |
| private int year; | |
| public Year(int year) { | |
| this.year = year; | |
| } | |
| public boolean isLeapYear() { | |
| return isDivisibleBy(4) | |
| && (isNotDivisibleBy(100) | |
| || isDivisibleBy(400)); | |
| } | |
| private boolean isDivisibleBy(int number) { | |
| return this.year % number == 0; | |
| } | |
| private boolean isNotDivisibleBy(int number) { | |
| return this.year % number != 0; | |
| } | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment