Skip to content

Instantly share code, notes, and snippets.

@Sean-Der
Created February 18, 2019 18:45
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save Sean-Der/ff9bb7f7f6a51f8c54f49a38fafd0213 to your computer and use it in GitHub Desktop.
Save Sean-Der/ff9bb7f7f6a51f8c54f49a38fafd0213 to your computer and use it in GitHub Desktop.
diff --git a/go.mod b/go.mod
index 4c30ea5..182a19d 100644
--- a/go.mod
+++ b/go.mod
@@ -6,7 +6,7 @@ require (
github.com/pions/rtcp v1.0.0
github.com/pions/rtp v1.0.0
github.com/pions/sctp v1.3.1
- github.com/pions/sdp v1.3.0
+ github.com/pions/sdp/v2 v2.0.0
github.com/pions/srtp v1.0.3
github.com/pions/stun v0.2.0
github.com/pions/transport v0.1.0
diff --git a/go.sum b/go.sum
index a3e3eee..16e200a 100644
--- a/go.sum
+++ b/go.sum
@@ -32,8 +32,8 @@ github.com/pions/rtp v1.0.0/go.mod h1:GDIt4UYlSz7za4vfaLqihGJJ+yLvgPshnqrF/lm3vc
github.com/pions/sctp v1.3.0/go.mod h1:GZTG/xApE7wdUFEQq2Rmzgxl/+YaB/L1k8xUl1D5bmo=
github.com/pions/sctp v1.3.1 h1:V5cRHMt+G9ufc44ITZvcEj7/nUyDukkB3Qr08TT29k4=
github.com/pions/sctp v1.3.1/go.mod h1:GZTG/xApE7wdUFEQq2Rmzgxl/+YaB/L1k8xUl1D5bmo=
-github.com/pions/sdp v1.3.0 h1:HIv6ZvdzRPq+H4T8EV8K9pZ4EGnYOr14HFZ9Rksh6/0=
-github.com/pions/sdp v1.3.0/go.mod h1:moNMmnVSlx8rBBb39U9t0Rdr7xvMlqiJjHlMESRad5k=
+github.com/pions/sdp/v2 v2.0.0 h1:tWh8ehKPtXTaFYF12sBAHqYmhV36Q7YTmm3O6ycNa6M=
+github.com/pions/sdp/v2 v2.0.0/go.mod h1:KGRBcHfpkgJXjrzKJz2wj/Jf1KWnsHdoIiqtayQ5QmE=
github.com/pions/srtp v1.0.3 h1:0rlg7yUHQblFA1e451mhx50IkA7+e48ja5K8mljyMYY=
github.com/pions/srtp v1.0.3/go.mod h1:egXe0STDyQDXLm7hjOMzuk7rkAhJ1SHOx+tTgtw/cQs=
github.com/pions/stun v0.2.0 h1:spIzpfkEg6HV+2iIo6qeOsAjtadZKzbXbrd2e9ZCCcs=
diff --git a/mediaengine.go b/mediaengine.go
index 4593f02..d35a5a2 100644
--- a/mediaengine.go
+++ b/mediaengine.go
@@ -5,7 +5,7 @@ import (
"github.com/pions/rtp"
"github.com/pions/rtp/codecs"
- "github.com/pions/sdp"
+ "github.com/pions/sdp/v2"
)
// PayloadTypes for the default codecs
diff --git a/mediaengine_test.go b/mediaengine_test.go
index e4f31a7..c220b63 100644
--- a/mediaengine_test.go
+++ b/mediaengine_test.go
@@ -3,7 +3,7 @@ package webrtc
import (
"testing"
- "github.com/pions/sdp"
+ "github.com/pions/sdp/v2"
"github.com/stretchr/testify/assert"
)
diff --git a/rtcicecandidate.go b/rtcicecandidate.go
index 19d0916..d492959 100644
--- a/rtcicecandidate.go
+++ b/rtcicecandidate.go
@@ -5,7 +5,7 @@ import (
"fmt"
"net"
- "github.com/pions/sdp"
+ "github.com/pions/sdp/v2"
"github.com/pions/webrtc/pkg/ice"
)
diff --git a/rtcicecandidate_test.go b/rtcicecandidate_test.go
index 1b1223e..0fbc4f1 100644
--- a/rtcicecandidate_test.go
+++ b/rtcicecandidate_test.go
@@ -4,7 +4,7 @@ import (
"net"
"testing"
- "github.com/pions/sdp"
+ "github.com/pions/sdp/v2"
"github.com/pions/webrtc/pkg/ice"
"github.com/stretchr/testify/assert"
)
diff --git a/rtcpeerconnection.go b/rtcpeerconnection.go
index 48f218a..956f9d1 100644
--- a/rtcpeerconnection.go
+++ b/rtcpeerconnection.go
@@ -14,7 +14,7 @@ import (
"github.com/pions/rtcp"
"github.com/pions/rtp"
- "github.com/pions/sdp"
+ "github.com/pions/sdp/v2"
"github.com/pions/webrtc/pkg/ice"
"github.com/pions/webrtc/pkg/logging"
"github.com/pions/webrtc/pkg/rtcerr"
@@ -889,7 +889,7 @@ func (pc *RTCPeerConnection) openSRTP() {
continue
}
- if attr.Key == sdp.AttrKeySsrc {
+ if attr.Key == sdp.AttrKeySSRC {
ssrc, err := strconv.ParseUint(strings.Split(attr.Value, " ")[0], 10, 32)
if err != nil {
pcLog.Warnf("Failed to parse SSRC: %v", err)
@@ -1433,8 +1433,8 @@ func (pc *RTCPeerConnection) addRTPMediaSection(d *sdp.SessionDescription, codec
WithValueAttribute(sdp.AttrKeyConnectionSetup, dtlsRole.String()). // TODO: Support other connection types
WithValueAttribute(sdp.AttrKeyMID, midValue).
WithICECredentials(iceParams.UsernameFragment, iceParams.Password).
- WithPropertyAttribute(sdp.AttrKeyRtcpMux). // TODO: support RTCP fallback
- WithPropertyAttribute(sdp.AttrKeyRtcpRsize) // TODO: Support Reduced-Size RTCP?
+ WithPropertyAttribute(sdp.AttrKeyRTCPMux). // TODO: support RTCP fallback
+ WithPropertyAttribute(sdp.AttrKeyRTCPRsize) // TODO: Support Reduced-Size RTCP?
for _, codec := range pc.api.mediaEngine.getCodecsByKind(codecType) {
media.WithCodec(codec.PayloadType, codec.Name, codec.ClockRate, codec.Channels, codec.SdpFmtpLine)
diff --git a/rtcsessiondescription.go b/rtcsessiondescription.go
index 170ac31..37db010 100644
--- a/rtcsessiondescription.go
+++ b/rtcsessiondescription.go
@@ -1,7 +1,7 @@
package webrtc
import (
- "github.com/pions/sdp"
+ "github.com/pions/sdp/v2"
)
// RTCSessionDescription is used to expose local and remote session descriptions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment