Skip to content

Instantly share code, notes, and snippets.

@Xliff
Created March 12, 2020 12:39
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save Xliff/217a6e7433312e117752334678ae1bf7 to your computer and use it in GitHub Desktop.
Save Xliff/217a6e7433312e117752334678ae1bf7 to your computer and use it in GitHub Desktop.

Eep! How did this happen?

Stage start      :   0.000

    precomp lib/Goo/Polyline.pm6
    --stagestats
    --stagestats
    --stagestats
    --stagestats
    --stagestats
    --stagestats
    --stagestats
    --stagestats
    --stagestats
    --stagestats
    --stagestats
    --stagestats
    --stagestats
    --stagestats
    --stagestats
    --stagestats
Stage parse      :   8.196
Stage syntaxcheck:   0.000
Stage ast        :   0.000
Stage optimize   :   0.001
Stage mast       :   0.003
Stage mbc        :   0.000
Stage moar       :   0.000
@Xliff
Copy link
Author

Xliff commented Mar 12, 2020

This looks to be the problematic piece of code:

            if $stagestats {
                whenever $proc.stderr.lines {
                    note("    $stagestats");
                    $*ERR.flush;
                }
            }

This will output "--stagestats" for every line of $proc.stderr

@lizmat
Copy link

lizmat commented Mar 12, 2020

This appears to be the offending commit: rakudo/rakudo@c9d9a096e8

What I don't understand how that could have made a difference ?

@Xliff
Copy link
Author

Xliff commented Mar 12, 2020

Well, the original commit used $_ instead of $stagestats.

Minor mixup?

@lizmat
Copy link

lizmat commented Mar 12, 2020

Aah... duh...! The with was used for the defined test, not for setting the topic! Indeed, a minor mixup.

@lizmat
Copy link

lizmat commented Mar 12, 2020

@lizmat
Copy link

lizmat commented Mar 12, 2020

Seems we don't have tests for this case, would you care to add some?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment