Skip to content

Instantly share code, notes, and snippets.

View aaronbates's full-sized avatar

Aaron Bates aaronbates

View GitHub Profile
@aaronbates
aaronbates / gist:920d87c823009f69776d663533e3a02c
Last active February 14, 2024 14:18
Social sign-in redirect URI/URL issues

ℹ️ The context here is we started to see users land on our signed in experience (app.datacamp.com) after sign in from www.datacamp.com and throw unexpected errors on the root path / that were caught in our error monitoring system (Sentry).

Looking at visual sessions replays (we use Heap) we saw that users were presented with an unexpected blank which required a hard page reload to get the signed in dashboard to load.

It turns out that both Google and Facebook can append characters to the URL after sign in, this caused our JS page routing logic to fail. It's a shot in the dark, but it's possible there's some related issue for you, perhaps that you need to set a specific redirect URI in both Fb and Google, which is something we can't do as we need to redirect users dynamically to any potential signed in only URL if they try to access it when signed out.

Below is the PR description of the fix we put in place:


aaron-bond.better-comments
alefragnani.Bookmarks
alefragnani.project-manager
arcticicestudio.nord-visual-studio-code
asvetliakov.snapshot-tools
bibhasdn.unique-lines
BriteSnow.vscode-toggle-quotes
bung87.rails
bung87.vscode-gemfile
castwide.solargraph

Keybase proof

I hereby claim:

  • I am aaronbates on github.
  • I am aaronbates (https://keybase.io/aaronbates) on keybase.
  • I have a public key ASCIeXlomZ_0jdch36LfxRI7JHw1_UM9JhqrsZfS7r5LUQo

To claim this, I am signing this object: