Navigation Menu

Skip to content

Instantly share code, notes, and snippets.

@adityatyagi

adityatyagi/PULL_REQUEST_TEMPLATE.md

Created July 20, 2022 16:10
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save adityatyagi/b35a3defec3c5ae94990f0a4770fd4bb to your computer and use it in GitHub Desktop.
Save adityatyagi/b35a3defec3c5ae94990f0a4770fd4bb to your computer and use it in GitHub Desktop.
Download ZIP
Raw
PULL_REQUEST_TEMPLATE.md

Ticket

Ticket ID: https://JIRA.com/ABC-1234

Description:

Added lazy loading in the app

Testing Steps:

  1. Run the app
  2. Open Google Dev Tools
  3. Open different modules and when you do, keep a close eye on the network tabs. You'll see the request for new JS chunks for these modules going in real time i.e. on demand

Screenshots:

image

Required Checklist

  1. Is UX approved by designers, leads and product?

    • yes
    • N/A

  2. Is UI verified at different resolutions?

    • yes
    • no
    • N/A

  3. If new images are added, then they are in optimal format and are compressed appropriately with alt text.

    • yes
    • no
    • N/A

  4. Changes to reusable components do not break other parts of the code.

    • yes
    • N/A

  5. Unit tests are passing and coverage thresholds have been met (and raised if coverage improved)

    • yes
    • N/A

  6. Have you self-reviewed your PR?

    • yes
    • N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment