tt notes

notes1.md

• https://github.com/commons-stack/tech-token/blob/master/contracts/Controlled.sol#L8
  • why payable?
• https://github.com/commons-stack/tech-token/blob/master/contracts/DAI.sol
  • I usually put those files under /contracts/test/ to avoid confussion, but maybe is better under /test (=?)
  • DAIMock name could also give some information about
• https://github.com/commons-stack/tech-token/blob/eda21b2ac116604225b75ecea69ac49a993353f7/contracts/MiniMeToken.sol#L43
  • Known versions are MNT_0.1 and MNT_0.2 (last official one, https://github.com/Giveth/minime/blob/master/contracts/MiniMeToken.sol), but you are using the version MMT_1 (without minor). Where this version comes from?
• https://github.com/commons-stack/tech-token/blob/master/contracts/TechController.sol#L25
  • aestethics blahblah, better to remove dead code
• https://github.com/commons-stack/tech-token/blob/master/contracts/TechController.sol#L124
  • it seems that contributionCap[address] has the invariant to be an accumulator-only, so, in order not to break it, maybe makes sense to assert that maxcontribution > contributionCap[_account]
• https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/access/roles/WhitelistedRole.sol#L38
  • at this moment an user can call renounceWhitelisted to remove itself from the whitelist, it makes sense?