Skip to content

Instantly share code, notes, and snippets.

@ancorgs
Last active October 7, 2020 13:06
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save ancorgs/e8886face86fd6a8ea815e51963840ee to your computer and use it in GitHub Desktop.
Save ancorgs/e8886face86fd6a8ea815e51963840ee to your computer and use it in GitHub Desktop.

Moving qgroup probing/editing to libstorage-ng

Reasons to do it

  • The same mounting used to probe the subvolumes could be used to probe the qgroups.

  • The same mounting used during the libstorage-ng's commit phase to create the subvolumes could be used to modify the qgroups.

  • The libstorage-ng's actiongraph would contain the actions to modify the qgroups, no need to "enrich" it with additional compound actions in the Ruby layer.

  • Waiting/forcing for device synchronization is so far libstorage-ng's bussiness (calls to udevadm settle, etc). and is likely also needed for gqroups (rescan and sync).

How it should be

The content of this section was moved to https://jira.suse.com/browse/SLE-16696. See the bullet points in the description there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment