Skip to content

Instantly share code, notes, and snippets.

@bcoe
Created January 23, 2019 23:53
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save bcoe/3da34e96068f108dbe99eedcb7b11cf7 to your computer and use it in GitHub Desktop.
Save bcoe/3da34e96068f108dbe99eedcb7b11cf7 to your computer and use it in GitHub Desktop.
fail-on-threshold.patch
diff --git a/Makefile b/Makefile
index 9fcf7e08701..852697c53fd 100644
--- a/Makefile
+++ b/Makefile
@@ -215,7 +215,7 @@ coverage-build: all
coverage-build-js:
mkdir -p node_modules
if [ ! -d node_modules/c8 ]; then \
- $(NODE) ./deps/npm install c8@next --no-save --no-package-lock;\
+ $(NODE) ./deps/npm install c8 --no-save --no-package-lock;\
fi
.PHONY: coverage-test
@@ -226,7 +226,7 @@ coverage-test: coverage-build
$(RM) out/$(BUILDTYPE)/obj.target/node_lib/gen/*.gcda
$(RM) out/$(BUILDTYPE)/obj.target/node_lib/src/*.gcda
$(RM) out/$(BUILDTYPE)/obj.target/node_lib/src/tracing/*.gcda
- -NODE_V8_COVERAGE=out/$(BUILDTYPE)/.coverage $(MAKE) $(COVTESTS)
+ NODE_V8_COVERAGE=out/$(BUILDTYPE)/.coverage $(MAKE) $(COVTESTS)
$(MAKE) coverage-report-js
-(cd out && "../gcovr/scripts/gcovr" --gcov-exclude='.*deps' \
--gcov-exclude='.*usr' -v -r Release/obj.target \
@@ -245,6 +245,11 @@ coverage-report-js:
--temp-directory=out/$(BUILDTYPE)/.coverage --omit-relative=false \
--resolve=./lib --exclude="deps/" --exclude="test/" --exclude="tools/" \
--wrapper-length=0
+ @if [ $(COV_ENFORCE_THRESHOLD) = "1" ]; then \
+ $(NODE) ./node_modules/.bin/c8 check-coverage --lines=90 --resolve=./lib \
+ --temp-directory=out/$(BUILDTYPE)/.coverage --omit-relative=false \
+ --exclude="deps/" --exclude="test/"; \
+ fi
.PHONY: cctest
# Runs the C++ tests using the built `cctest` executable.
@@ -276,7 +281,7 @@ jstest: build-addons build-js-native-api-tests build-node-api-tests ## Runs addo
coverage-run-js:
$(RM) -r out/$(BUILDTYPE)/.coverage
$(MAKE) coverage-build-js
- -NODE_V8_COVERAGE=out/$(BUILDTYPE)/.coverage CI_SKIP_TESTS=$(COV_SKIP_TESTS) \
+ NODE_V8_COVERAGE=out/$(BUILDTYPE)/.coverage CI_SKIP_TESTS=$(COV_SKIP_TESTS) \
$(MAKE) jstest
$(MAKE) coverage-report-js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment