Skip to content

Instantly share code, notes, and snippets.

Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save brandonbloom/8744556 to your computer and use it in GitHub Desktop.
Save brandonbloom/8744556 to your computer and use it in GitHub Desktop.
From 7fe409840207e3e68169c4dcdef5d4481d826369 Mon Sep 17 00:00:00 2001
From: Brandon Bloom <brandon@brandonbloom.name>
Date: Fri, 31 Jan 2014 17:28:39 -0500
Subject: [PATCH] Use catch :default in browser repl and reflect
---
src/cljs/clojure/browser/repl.cljs | 2 +-
src/cljs/clojure/reflect.cljs | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/cljs/clojure/browser/repl.cljs b/src/cljs/clojure/browser/repl.cljs
index 8d38f12..5038e4a 100644
--- a/src/cljs/clojure/browser/repl.cljs
+++ b/src/cljs/clojure/browser/repl.cljs
@@ -28,7 +28,7 @@
"Process a single block of JavaScript received from the server"
[conn block]
(let [result (try {:status :success :value (str (js* "eval(~{block})"))}
- (catch js/Error e
+ (catch :default e
{:status :exception :value (pr-str e)
:stacktrace (if (.hasOwnProperty e "stack")
(.-stack e)
diff --git a/src/cljs/clojure/reflect.cljs b/src/cljs/clojure/reflect.cljs
index 6dbd822..50589d9 100644
--- a/src/cljs/clojure/reflect.cljs
+++ b/src/cljs/clojure/reflect.cljs
@@ -5,7 +5,7 @@
(defn- evaluate-javascript [block]
(let [result (try (js* "eval(~{block})")
- (catch js/Error e
+ (catch :default e
(.log js/console e)))]
result))
--
1.8.5.3
@brandonbloom
Copy link
Author

Fixes issue @sgrove encountered where browser repl was crashing. Mentioning @swannodette too so this goes in his inbox where it won't be forgotten as easily as IRC :-)

edit: apparently I don't know how to mention people...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment