bugfix/search merged into HH-6 test failures

gistfile1.txt

Failures:

  1) CatalogController#index as an un-authenticated user should show results for items that are public and published
     Failure/Error: assigns(:document_list).count.should eql(1)
       
       expected: 1
            got: 0
       
       (compared using eql?)
     # ./spec/controllers/catalog_controller_spec.rb:11:in `block (4 levels) in <top (required)>'

  2) CatalogController#index as an authenticated user should show results for items that are published and available to registered users
     Failure/Error: assigns(:document_list).count.should eql(1)
       
       expected: 1
            got: 0
       
       (compared using eql?)
     # ./spec/controllers/catalog_controller_spec.rb:41:in `block (4 levels) in <top (required)>'

  3) CatalogController#index as a manager should show results for items that are unpublished, private, and belong to one of my collections
     Failure/Error: assigns(:document_list).count.should eql(1)
       
       expected: 1
            got: 0
       
       (compared using eql?)
     # ./spec/controllers/catalog_controller_spec.rb:68:in `block (4 levels) in <top (required)>'

  4) MediaObject Required metadata is present should require creator to be set
     Failure/Error: it {should validate_presence_of(:creator)}
       Expected errors to include "field is required." when creator is set to nil, got errors: ["title field is required. (nil)", "date_issued field is required. (nil)", "collection field is required. (nil)", "governing_policy field is required. (nil)"]
     # ./spec/models/media_object_spec.rb:127:in `block (3 levels) in <top (required)>'

  5) MediaObject discovery should set hidden?
     Failure/Error: media_object.to_solr[:hidden_bsi].should be_true
       expected: true value
            got: nil
     # ./spec/models/media_object_spec.rb:219:in `block (3 levels) in <top (required)>'

  6) MediaObject#publish! facet publishes
     Failure/Error: media_object.to_solr[:workflow_published_sim].should == 'Published'
       expected: "Published"
            got: "Unpublished" (using ==)
     # ./spec/models/media_object_spec.rb:303:in `block (4 levels) in <top (required)>'

  7) Collections GET /collections works! (now write some real specs)
     Failure/Error: get collections_path
     NameError:
       undefined local variable or method `collections_path' for #<RSpec::Core::ExampleGroup::Nested_22::Nested_1:0x0000000a3e7970>
     # ./spec/requests/collections_spec.rb:7:in `block (3 levels) in <top (required)>'

  8) Admin::CollectionsController routing routes to #index
     Failure/Error: get("/admin/collections").should route_to("collections#index")
       The recognized options <{"action"=>"index", "controller"=>"admin/collections"}> did not match <{"controller"=>"collections", "action"=>"index"}>, difference: <{"controller"=>"collections"}>.
       <{"controller"=>"collections", "action"=>"index"}> expected but was
       <{"action"=>"index", "controller"=>"admin/collections"}>.
     # ./spec/routing/collections_routing_spec.rb:7:in `block (3 levels) in <top (required)>'

  9) Admin::CollectionsController routing routes to #new
     Failure/Error: get("/admin/collections/new").should route_to("collections#new")
       The recognized options <{"action"=>"new", "controller"=>"admin/collections"}> did not match <{"controller"=>"collections", "action"=>"new"}>, difference: <{"controller"=>"collections"}>.
       <{"controller"=>"collections", "action"=>"new"}> expected but was
       <{"action"=>"new", "controller"=>"admin/collections"}>.
     # ./spec/routing/collections_routing_spec.rb:11:in `block (3 levels) in <top (required)>'

  10) Admin::CollectionsController routing routes to #show
     Failure/Error: get("/admin/collections/1").should route_to("collections#show", :id => "1")
       The recognized options <{"action"=>"show", "controller"=>"admin/collections", "id"=>"1"}> did not match <{"id"=>"1", "controller"=>"collections", "action"=>"show"}>, difference: <{"controller"=>"collections"}>.
       <{"id"=>"1", "controller"=>"collections", "action"=>"show"}> expected but was
       <{"action"=>"show", "controller"=>"admin/collections", "id"=>"1"}>.
     # ./spec/routing/collections_routing_spec.rb:15:in `block (3 levels) in <top (required)>'

  11) Admin::CollectionsController routing routes to #edit
     Failure/Error: get("/admin/collections/1/edit").should route_to("collections#edit", :id => "1")
       The recognized options <{"action"=>"edit", "controller"=>"admin/collections", "id"=>"1"}> did not match <{"id"=>"1", "controller"=>"collections", "action"=>"edit"}>, difference: <{"controller"=>"collections"}>.
       <{"id"=>"1", "controller"=>"collections", "action"=>"edit"}> expected but was
       <{"action"=>"edit", "controller"=>"admin/collections", "id"=>"1"}>.
     # ./spec/routing/collections_routing_spec.rb:19:in `block (3 levels) in <top (required)>'

  12) Admin::CollectionsController routing routes to #create
     Failure/Error: post("/admin/collections").should route_to("collections#create")
       The recognized options <{"action"=>"create", "controller"=>"admin/collections"}> did not match <{"controller"=>"collections", "action"=>"create"}>, difference: <{"controller"=>"collections"}>.
       <{"controller"=>"collections", "action"=>"create"}> expected but was
       <{"action"=>"create", "controller"=>"admin/collections"}>.
     # ./spec/routing/collections_routing_spec.rb:23:in `block (3 levels) in <top (required)>'

  13) Admin::CollectionsController routing routes to #update
     Failure/Error: put("/admin/collections/1").should route_to("collections#update", :id => "1")
       The recognized options <{"action"=>"update", "controller"=>"admin/collections", "id"=>"1"}> did not match <{"id"=>"1", "controller"=>"collections", "action"=>"update"}>, difference: <{"controller"=>"collections"}>.
       <{"id"=>"1", "controller"=>"collections", "action"=>"update"}> expected but was
       <{"action"=>"update", "controller"=>"admin/collections", "id"=>"1"}>.
     # ./spec/routing/collections_routing_spec.rb:27:in `block (3 levels) in <top (required)>'

  14) Admin::CollectionsController routing routes to #destroy
     Failure/Error: delete("/admin/collections/1").should route_to("collections#destroy", :id => "1")
       The recognized options <{"action"=>"destroy", "controller"=>"admin/collections", "id"=>"1"}> did not match <{"id"=>"1", "controller"=>"collections", "action"=>"destroy"}>, difference: <{"controller"=>"collections"}>.
       <{"id"=>"1", "controller"=>"collections", "action"=>"destroy"}> expected but was
       <{"action"=>"destroy", "controller"=>"admin/collections", "id"=>"1"}>.
     # ./spec/routing/collections_routing_spec.rb:31:in `block (3 levels) in <top (required)>'

  15) collections/edit renders the edit collection form
     Failure/Error: @collection = assign(:collection, stub_model(Collection))
     NameError:
       uninitialized constant Collection
     # ./spec/views/collections/edit.html.erb_spec.rb:5:in `block (2 levels) in <top (required)>'

  16) collections/index renders a list of collections
     Failure/Error: stub_model(Collection),
     NameError:
       uninitialized constant Collection
     # ./spec/views/collections/index.html.erb_spec.rb:6:in `block (2 levels) in <top (required)>'

  17) collections/new renders new collection form
     Failure/Error: assign(:collection, stub_model(Collection).as_new_record)
     NameError:
       uninitialized constant Collection
     # ./spec/views/collections/new.html.erb_spec.rb:5:in `block (2 levels) in <top (required)>'

  18) collections/show renders attributes in <p>
     Failure/Error: @collection = assign(:collection, stub_model(Collection))
     NameError:
       uninitialized constant Collection
     # ./spec/views/collections/show.html.erb_spec.rb:5:in `block (2 levels) in <top (required)>'

For #4: This is really confusing ...

[43] pry(main)> mo = MediaObject.new
DEPRECATION WARNING: NokogiriDatastream is deprecated and will be removed in hydra-head 7.0. Use OmDatastream insead. (called from new at /home/cjcolvar/.rvm/gems/ruby-1.9.3-p194@avalon/gems/active-fedora-6.4.2/lib/active_fedora/digital_object.rb:10)
DEPRECATION WARNING: NokogiriDatastream is deprecated and will be removed in hydra-head 7.0. Use OmDatastream insead. (called from new at /home/cjcolvar/.rvm/gems/ruby-1.9.3-p194@avalon/gems/active-fedora-6.4.2/lib/active_fedora/digital_object.rb:10)
DEPRECATION WARNING: NokogiriDatastream is deprecated and will be removed in hydra-head 7.0. Use OmDatastream insead. (called from new at /home/cjcolvar/.rvm/gems/ruby-1.9.3-p194@avalon/gems/active-fedora-6.4.2/lib/active_fedora/digital_object.rb:10)
=> #<MediaObject pid:"", avalon_uploader:nil, avalon_publisher:nil, title:nil, alternative_title:[], translated_title:[], uniform_title:[], statement_of_responsibility:nil, creator:[], date_created:nil, date_issued:nil, copyright_date:nil, abstract:nil, note:[], format:nil, contributor:[], publisher:[], genre:[], subject:[], related_item:[], geographic_subject:[], temporal_subject:[], topical_subject:[], duration:nil, section_pid:[]>
[44] pry(main)> mo.creator
=> []
[45] pry(main)> mo.creator = nil
=> nil
[46] pry(main)> mo.creator
=> [""]
[47] pry(main)> mo.creator = nil
=> nil
[48] pry(main)> mo.creator
=> []