Skip to content

Instantly share code, notes, and snippets.

@cwoffenden
Created January 12, 2021 18:18
Show Gist options
  • Save cwoffenden/98761d0e74a32cc8d9d12f931f8ef805 to your computer and use it in GitHub Desktop.
Save cwoffenden/98761d0e74a32cc8d9d12f931f8ef805 to your computer and use it in GitHub Desktop.
Instructions for getting patches into Dawn (and similar Gerrit projects)

Dawn

Project main URL:

https://dawn.googlesource.com/dawn/

Bug tracker:

https://bugs.chromium.org/p/dawn/

Gerrit code review:

https://dawn-review.googlesource.com/

Chatroom:

https://matrix.to/#/#WebGPU:matrix.org

Before submitting any code sign the CLA:

https://cla.developers.google.com/

(Numfum staff already have this signed company-wide)

Log into Gerrit and generate a HTTP password for the Git commits:

https://dawn-review.googlesource.com/new-password

(Follow the instructions shown to add this as a Git cookie)

Check-out Dawn, if it isn't already, then (as per the ANGLE docs) copy the Git commit message hook to add the Change-ID to each commit:

https://chromium.googlesource.com/angle/angle/+/HEAD/doc/ContributingCode.md#getting-started-with-gerrit-for-angle

The ANGLE link also covers this but to summarise:

Show any changes:

git status

Add changed files to the commit:

git add path/to/file

Commit the files along with a commit message:

git commit

In Windows Notepad will open. The message format should be a title on the first line, an empty line, the message body, followed by a newline. The commit hook will add the Change-ID.

Any mistakes/unwanted commits can be rolled back with:

git reset --hard HEAD~1

Then to push this to Gerrit use:

git push origin HEAD:refs/for/HEAD

This will add a new entry in the Gerrit dashboard:

https://dawn-review.googlesource.com/dashboard/self

This will need changing from Draft to Active, the 'CQ Dry Run' running, then reviewers adding (with the Reply button?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment