Skip to content

Instantly share code, notes, and snippets.

@danbogd

danbogd/ETH_Maker_audit_report.md Secret

Created March 22, 2019 10:14
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 1 You must be signed in to fork a gist
  • Save danbogd/3fcf329173eac83a4864ec18ef99acf9 to your computer and use it in GitHub Desktop.
Save danbogd/3fcf329173eac83a4864ec18ef99acf9 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
ETH_Maker_audit_report.md

Maker audit report.

1. Summary

This document is a security audit report performed by danbogd, where Maker has been reviewed.

2. In scope

3. Findings

In total, 2 issues were reported including:

  • 1 low severity issues.
  • 1 minor observation.

3.1. Known vulnerabilities of ERC-20 token

Severity: low

Description

  1. It is possible to double withdrawal attack. More details here.

  2. Lack of transaction handling mechanism issue. WARNING! This is a very common issue and it already caused millions of dollars losses for lots of token users! More details here.

Recommendation

Add into a function transfer(address _to, ... ) following code:

require( _to != address(this) );

3.2. Consider using latest version of solidity.

Severity: minor observation

Description

The contracts use solidity version 0.4.15. It is suggested to use the latest version and fix all compiler warnings that arise. Compiler version should be fixed to avoid any potential discrepancies in smart contract behavior caused by different versions of compiler.

4. Conclusion

The audited smart contract is safe to deploy. Some low severity issues were found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment