Simple script to generate ppm files from jpegs using 'imagemagick' and pacman package manager

convert_ppm.sh

#! /bin/bash

# check for arguments
if [ $# -eq 0 ]
then
	# no args passed
	echo "Usage: ./convert_ppm.sh <input file> <output file>"
	exit 1
fi

# check for imagemagick dependency
pacman -Qi imagemagick > /dev/null

if [ $? -ne 0 ]
then
	# missing dependency
	echo "Missing dependency 'imagemagick'. Installing..."
	sudo pacman -S imagemagick --noconfirm
fi
	
# converting
convert $1 -compress none -set comment \"\" $2
sed -i '/^#/d' $2

One could eliminate duplicate code by moving the conversion code out as we want to convert the image in both cases (if ImageMagick is installed and if we freshly installed ImageMagick)

if [ $? -ne 0 ]
then
	# missing dependency
	echo "Missing dependency 'ImageMagick'. Installing..."
	sudo pacman -S imagemagick --noconfirm
fi

# converting
convert $1 -compress none -set comment \"\" $2
sed -i '/^#/d' $2

Of course you're right. But for me this didn't play a role for a script, that had the only purpose to free me from remembering command names :) But you've got a point anyway. For a script that has to be published in any professional sense, these "Blemishes" should have been changed in any case.

One could eliminate duplicate code by moving the conversion code out as we want to convert the image in both cases (if ImageMagick is installed and if we freshly installed ImageMagick)

if [ $? -ne 0 ]
then
	# missing dependency
	echo "Missing dependency 'ImageMagick'. Installing..."
	sudo pacman -S imagemagick --noconfirm
fi

# converting
convert $1 -compress none -set comment \"\" $2
sed -i '/^#/d' $2

I got some time and I have realized your suggestion for improvement :)