Chris dennda
dennda
/ gist:541958426efe6b34ce70e3d8c3aa3d52
Created
July 25, 2018 16:51
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Data retrieved from https://api.duolingo.com/internal_api/1/trees/inspect?id=<tree_id> | |
| 3cdc03288e3c6f85b686b505cbfe29f3: | |
| learning_language: | |
| abbrev: es | |
| id: es | |
| from_language: | |
| id: en | |
| version: | |
| 22 | |
| skills: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| diff --git a/DuolingoMobile/Sources/Sessions/Controllers/DUOSessionViewController.m b/DuolingoMobile/Sources/Sessions/Controllers/DUOSessionViewController.m | |
| index 585b7cfac..b44530f2e 100644 | |
| --- a/DuolingoMobile/Sources/Sessions/Controllers/DUOSessionViewController.m | |
| +++ b/DuolingoMobile/Sources/Sessions/Controllers/DUOSessionViewController.m | |
| @@ -704,9 +704,11 @@ - (BOOL)shouldAutorotate | |
| - (BOOL)allowDisplayOfCharacters | |
| { | |
| + DUOUser *user = self.userClient.user; | |
| + |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| commit 3c1d735f02d64cdd8890b394524987401afcecd1 | |
| Author: Christopher Denter <c@denter.org> | |
| Date: Wed Jun 20 12:59:43 2018 +0200 | |
| XPLAIN: Fix an issue where audio sample cells would override their descriptions text attributes. | |
| diff --git a/DuolingoMobile/Sources/Explanations/ExplanationCells.swift b/DuolingoMobile/Sources/Explanations/ExplanationCells.swift | |
| index 5ee3b04ac..37def6bc2 100644 | |
| --- a/DuolingoMobile/Sources/Explanations/ExplanationCells.swift | |
| +++ b/DuolingoMobile/Sources/Explanations/ExplanationCells.swift |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| diff --git a/DuolingoMobile/Metadata/DuolingoMobile-Info.plist b/DuolingoMobile/Metadata/DuolingoMobile-Info.plist | |
| index d3fa5550e..71cdb2d3a 100644 | |
| --- a/DuolingoMobile/Metadata/DuolingoMobile-Info.plist | |
| +++ b/DuolingoMobile/Metadata/DuolingoMobile-Info.plist | |
| @@ -17,7 +17,7 @@ | |
| <key>CFBundlePackageType</key> | |
| <string>APPL</string> | |
| <key>CFBundleShortVersionString</key> | |
| - <string>5.2.29</string> | |
| + <string>5.2.30</string> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| diff --git a/DuolingoMobile/Metadata/DuolingoMobile-Info.plist b/DuolingoMobile/Metadata/DuolingoMobile-Info.plist | |
| index f7468fd02..24042ace7 100644 | |
| --- a/DuolingoMobile/Metadata/DuolingoMobile-Info.plist | |
| +++ b/DuolingoMobile/Metadata/DuolingoMobile-Info.plist | |
| @@ -17,7 +17,7 @@ | |
| <key>CFBundlePackageType</key> | |
| <string>APPL</string> | |
| <key>CFBundleShortVersionString</key> | |
| - <string>5.2.26</string> | |
| + <string>5.2.30</string> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| diff --git a/DuolingoMobile/Metadata/DuolingoMobile-Info.plist b/DuolingoMobile/Metadata/DuolingoMobile-Info.plist | |
| index f7468fd02..24042ace7 100644 | |
| --- a/DuolingoMobile/Metadata/DuolingoMobile-Info.plist | |
| +++ b/DuolingoMobile/Metadata/DuolingoMobile-Info.plist | |
| @@ -17,7 +17,7 @@ | |
| <key>CFBundlePackageType</key> | |
| <string>APPL</string> | |
| <key>CFBundleShortVersionString</key> | |
| - <string>5.2.26</string> | |
| + <string>5.2.30</string> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| diff --git a/DuolingoMobile/Sources/Explanations/StyledString.swift b/DuolingoMobile/Sources/Explanations/StyledString.swift | |
| index 012e1ff3d..90fc0af5c 100644 | |
| --- a/DuolingoMobile/Sources/Explanations/StyledString.swift | |
| +++ b/DuolingoMobile/Sources/Explanations/StyledString.swift | |
| @@ -135,6 +135,16 @@ struct StyledString: Decodable { | |
| attributedString.addAttributes(attributes, range: range) | |
| } | |
| + if attributedString.string.hasSuffix("manzana") { | |
| +// attributedString.replaceCharacters(in: NSRange(location: 0, length: 9), with: " ") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| diff --git a/DuolingoMobile/Sources/Explanations/ExplanationCells.swift b/DuolingoMobile/Sources/Explanations/ExplanationCells.swift | |
| index b29ff18c1..aa34831f2 100644 | |
| --- a/DuolingoMobile/Sources/Explanations/ExplanationCells.swift | |
| +++ b/DuolingoMobile/Sources/Explanations/ExplanationCells.swift | |
| @@ -209,7 +209,7 @@ class OptionsCell: ExplanationCell { | |
| let missingButtons = max(0, model.count - buttons.count) | |
| if missingButtons > 0 { | |
| let newButtons = (0..<missingButtons).map { _ in | |
| - OptionsCell.makeButton() | |
| + OptionsCell.makeButton(target: self) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| diff --git a/DuolingoMobile/Metadata/DuolingoMobile-Info.plist b/DuolingoMobile/Metadata/DuolingoMobile-Info.plist | |
| index 158fdec12..89b58155a 100644 | |
| --- a/DuolingoMobile/Metadata/DuolingoMobile-Info.plist | |
| +++ b/DuolingoMobile/Metadata/DuolingoMobile-Info.plist | |
| @@ -17,7 +17,7 @@ | |
| <key>CFBundlePackageType</key> | |
| <string>APPL</string> | |
| <key>CFBundleShortVersionString</key> | |
| - <string>5.2.18</string> | |
| + <string>5.2.20</string> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| diff --git a/DuolingoMobile/Sources/Library/Networking/NetworkClient/Models/DUOSkill.swift b/DuolingoMobile/Sources/Library/Networking/NetworkClient/Models/DUOSkill.swift | |
| index f8d3c1fa6..e047ffdad 100644 | |
| --- a/DuolingoMobile/Sources/Library/Networking/NetworkClient/Models/DUOSkill.swift | |
| +++ b/DuolingoMobile/Sources/Library/Networking/NetworkClient/Models/DUOSkill.swift | |
| @@ -8,139 +8,140 @@ | |
| import Foundation | |
| -final class DUOSkill: NSObject, DUOCoding { | |
| - |