PSR-11 adapter for Nette DI Container

Psr11ContainerAdapter.md

See https://doc.nette.org/en/dependency-injection/nette-container#toc-psr-11-container

Hey David, just wanted to let you know that this PSR-11 adapter is not correct.

First: in your get($id) implementation, you're throwing a Psr\Container\NotFoundException. There's no Psr\Container\NotFoundException in PSR-11, there's only a Psr\Container\NotFoundExceptionInterface interface which — being an interface — cannot be instantiated and thrown. You have to create an exception that implements it — and throw that.

Second: get($id) has to throw an exception implementing Psr\Container\ContainerExceptionInterface interface if resolving $id fails (for whatever reason) — this adapter is not doing that at all. You have to wrap return $this->netteContainer->getService($id); in a try...catch block to catch any thrown exception and if that happens — throw an exception implementing Psr\Container\ContainerExceptionInterface interface.

It should look something like this:

<?php

declare(strict_types=1);

use Psr\Container\ContainerInterface;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
use Nette\DI\Container;

// ↓ For the sake of this example, I'm implementing these two    ↓
// ↓ Exceptions here, but they should be in their own namespace, ↓
// ↓ as should Psr11ContainerAdapter for that matter:            ↓
class Psr11ContainerException extends Exception implements ContainerExceptionInterface {}
class Psr11NotFoundException extends Psr11ContainerException implements NotFoundExceptionInterface {}

class Psr11ContainerAdapter implements ContainerInterface
{
    public function __construct(private Container $netteContainer) 
    {
        //
    }

    public function get($id)
    {
        if ( ! $this->netteContainer->hasService($id)) {
            throw new Psr11NotFoundException("Service not found: {$id}");
        }

        try {
            return $this->netteContainer->getService($id);
        } catch (Throwable $th) {
            throw new Psr11ContainerException("Failed to resolve service: {$id}", previous: $th); 
        }
    }

    public function has($id)
    {
        return $this->netteContainer->hasService($id);
    }
}


// usage:
// $psr11Adapter = new Psr11ContainerAdapter($netteContainer);

@michkozak thanks, I updated the code.