Skip to content

Instantly share code, notes, and snippets.

@dgdavid

dgdavid/Week 34.md

Last active August 24, 2018 08:58
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save dgdavid/2a625929be022e2f5a8b3a68eae169dd to your computer and use it in GitHub Desktop.
Save dgdavid/2a625929be022e2f5a8b3a68eae169dd to your computer and use it in GitHub Desktop.
Download ZIP
Raw
Week 34.md

Doing

  • Using ServiceWidget in fcoe-client module

Done

  • Proposed a RFC PR for https://trello.com/c/XZUCetog/160-create-new-exception-for-failure-when-refreshing-a-service

  • Discussed at office if it was really necessary now to distinguish the Systemctl#excute exception for show command (aka refresh). Conclusions:

    • Discard the idea for now and be consistent returning false as soon something went wrong.
    • Catch the SystemctlError also in Yast2::SystemService#save_start_mode, registering an "start_mode" error.

  • Updated the yast/yast-yast2#799 from code review

  • Updated yast2 dependency for open PR related to Yast2::Systemd refactorization

  • Tested manually the Yast2::Systemd reorganization (in a virtual machine, using yast2 4.1.3)

  • Merged Yast2::Systemd reorganization PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment