Skip to content

Instantly share code, notes, and snippets.

@domenkozar

domenkozar/nixops-close.md

Created March 26, 2020 18:46
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save domenkozar/73a742b2888abaa7f4cae61ca01bc141 to your computer and use it in GitHub Desktop.
Save domenkozar/73a742b2888abaa7f4cae61ca01bc141 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
nixops-close.md

Hello!

Thank you for this PR.

In the past several months, some major changes have taken place in NixOps:

  1. Backends have been removed, preferring a plugin-based architecture. Here are some of them:

  2. NixOps Core has been updated to be Python 3 only, and at the same time, MyPy type hints have been added and are now strictly required during CI.

This is all accumulating in to what I hope will be a NixOps 2.0 release. There is a tracking issue for that: NixOS/nixops#1242 . It is possible that more core changes will be made to NixOps for this release, with a focus on simplifying NixOps core and making it easier to use and work on.

My hope is that by adding types and more thorough automated testing, it will be easier for contributors to make improvements, and for contributions like this one to merge in the future.

However, because of the major changes, it has become likely that this PR cannot merge right now as it is. The backlog of now-unmergable PRs makes it hard to see which ones are being kept up to date.

If you would like to see this merge, please bring it up to date with master and reopen it. If the or mypy type checking fails, please correct any issues and then reopen it. I will be looking primarily at open PRs whose tests are all green.

Thank you again for the work you've done here, I am sorry to be closing it now.

Graham

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment