Moved to bitcoin/bips#910
Last active
June 11, 2020 12:15
-
-
Save ethankosakovsky/268c52f018b94bea29a6e809381c05d6 to your computer and use it in GitHub Desktop.
Even worse would be people extracting full paths and putting the master seed manager seed into a standard wallet, so the HMAC there is almost a feature in making that unsupported/incompatible with BIP32 derivation paths below the derived seed.
Very true. No-one needs this standard to in order to export a BIP32 XPRV into another wallet that's looking for it. We'd just be suggesting a subpath to use, which isn't very interesting. Applying HMAC512 as a "firewall" or operational "barrier" is consistent with the rest of this standard and how it works.
So I'll change Coldcard (back) to making XPRV from the HMAC entropy, unless someone gives a reason otherwise.
out of interest which application do you have in mind for the XPRV? is there a coldcard mode for importing them?
Yes, Coldcard supports XPRV as a master secret (held in secure element). That's why it came up when I implemented this.
Author
I have added the reference to Coldcard implementation Coldcard/firmware#39, to the BIP pull request. Everything looks good from my side. Just awaiting the BIP number assignment.
Author
This proposal has become BIP85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Very true. No-one needs this standard to in order to export a BIP32 XPRV into another wallet that's looking for it. We'd just be suggesting a subpath to use, which isn't very interesting. Applying HMAC512 as a "firewall" or operational "barrier" is consistent with the rest of this standard and how it works.
So I'll change Coldcard (back) to making XPRV from the HMAC entropy, unless someone gives a reason otherwise.