Skip to content

Instantly share code, notes, and snippets.

Embed
What would you like to do?
email to dev-addons
Subject: AMO dev (addons-dev.allizom.org) is now running python3
----------------------------------------------------------------
tl;dr - addons-dev.allizom.org is running python 3.6 rather than 2.7; you shouldn't notice any difference but report any issues as usual to https://github.com/mozilla/addons/issues
Many years ago we decided/realized we were going to have to switch to python 3 because python 2.7 was deprecated and would eventually stop being patched for even security bugs. That EOL date was 1st January 2020. In early 2017 we started a plan to slowly upgrade/replace/remove/patch [1] all the 3rd party dependencies that addons-server relied on (there were many; it took a while) and in 2018 [2] we eventually got tests running (but not passing) on python3 on our Travis test suite. At the start of 2019 we started working in earnest [3] to fix the tests and blocking issues, and last week we finished fixing the tests. After some local testing indicated no obvious problems, we decided to deploy addons-dev with python3.
Given the number of changes we had to make, there will inevitably be a regression or two introduced, so issues should be logged on https://github.com/mozilla/addons/issues (if it's a general problem) or https://github.com/mozilla/addons-server/issues (if it's a problem with developer hub/reviewer tools/statistics dashboard). In particular look out for bugs with:
* Anything encoding/unicode related, make sure that your Chinese and emoji characters continue to work
* Reviews, uploads, git-storage, image previews - anything touching our storage might be subject to edge-cases with path-names, etc
In addition, for those who want to contribute to addons-server, note that after pulling the latest versions, docker-compose should change the "web" container to use python3. Our continuous integration platform for unit tests, Travis, runs tests with both Python versions for the time being.
AMO stage (addons.allizom.org) will continue to run python2.7 for at least another week, until we're fairly confident it's stable, then we'll later make the call about when to deploy python 3 to AMO prod (addons.mozilla.org)
[1] https://github.com/mozilla/addons-server/issues/4997
[2] https://github.com/mozilla/addons-server/pull/9345
[3] https://github.com/orgs/mozilla/projects/55
[4] https://github.com/mozilla/addons-server/issues/10639
--
Andrew Williamson
@EnTeQuAk

This comment has been minimized.

Copy link

commented Feb 12, 2019

Let's maybe add things to look out for in particular:

  • Anything encoding/unicode related, make sure that your Chinese and emoji characters continue to work
  • Reviews, uploads, git-storage, image previews, anything touching our storage might be subject to edge-cases with path-names etc

(thinking about more in a bit…)

@diox

This comment has been minimized.

Copy link

commented Feb 12, 2019

Add something like:

In addition, for those who want to contribute to addons-server, note that after pulling the latest versions, docker-compose should change the "web" container to use python3. Our continuous integration platform for unit tests, Travis, runs tests with both Python versions for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.