Skip to content

Instantly share code, notes, and snippets.

@florapdx

florapdx/pr_template.md

Created August 7, 2015 17:02
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save florapdx/a68e41aecf92ce5d9812 to your computer and use it in GitHub Desktop.
Save florapdx/a68e41aecf92ce5d9812 to your computer and use it in GitHub Desktop.
Download ZIP
Generic-ish pull request template for teams. Based on internal Sprintly PR Template made by [Justin Abrahms](https://github.com/justinabrahms)
Raw
pr_template.md

What's this PR do?

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots (if appropriate)

What gif best describes this PR or how it makes you feel?

Definition of Done:

  • Is there appropriate test coverage? (e.g. ChefSpec, Mocha/Chai, Python, etc.)
  • Does this PR require a Selenium test? (e.g. Browser-specific bugs or complicated UI bugs)
  • Does this PR require a regression test? All fixes require a regression test.
  • Does this PR require a blog post? If so, ensure marketing has signed off on content.
  • Does this require changes in/additions to internal or external documentation?
  • Does this add new dependencies? Does this require updating development environments?
  • Will this feature require a new piece of infrastructure be implemented?
  • Are any new services fully automated?
  • Does this PR require new Mixpanel or GA events?
  • Is there appropriate logging included?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment