Skip to content

Instantly share code, notes, and snippets.

@grantland
Last active December 27, 2022 20:51
Embed
What would you like to do?
RecyclerView item onClick

RecyclerView item onClick

RecyclerView does not have an OnItemClickListener like it's predecessor, ListView. However, detecting item clicks is pretty simple.

Set an OnClickListener in your ViewHolder creation:

private class MyAdapter extends RecyclerView.Adapter<MyAdapter.ViewHolder>  {

    public static class ViewHolder extends RecyclerView.ViewHolder
            implements View.OnClickListener {
        private String mItem;
        private TextView mTextView;

        public ViewHolder(View view) {
            super(view);
            view.setOnClickListener(this);
            mTextView = (TextView) view;
        }

        public void setItem(String item) {
            mItem = item;
            mTextView.setText(item);
        }

        @Override
        public void onClick(View view) {
            Log.d(TAG, "onClick " + getPosition() + " " + mItem);
        }
    }

    private String[] mDataset;

    public MyAdapter(String[] dataset) {
        mDataset = dataset;
    }

    @Override
    public ViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
        View v = LayoutInflater.from(parent.getContext())
                .inflate(R.layout.list_item, parent, false);
        ViewHolder vh = new ViewHolder(v);
        return vh;
    }

    @Override
    public void onBindViewHolder(ViewHolder holder, int position) {
        holder.setItem(mDataset[position]);
    }

    @Override
    public int getItemCount() {
        return mDataset.length;
    }
}

Add touch feedback to your item layout:

<?xml version="1.0" encoding="utf-8"?>
<TextView xmlns:android="http://schemas.android.com/apk/res/android"
    android:id="@android:id/text1"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:textAppearance="?android:attr/textAppearanceListItemSmall"
    android:gravity="center_vertical"
    android:paddingStart="?android:attr/listPreferredItemPaddingStart"
    android:paddingEnd="?android:attr/listPreferredItemPaddingEnd"
    android:minHeight="?android:attr/listPreferredItemHeightSmall"
    android:background="?android:attr/selectableItemBackground"
/>
@IgorGanapolsky
Copy link

@jacobtabak Read the comment in the solution you linked to:

This will not provide any clue about which button or view (within the item) was clicked.

@dinesh-gadri
Copy link

how to delete row in recycler view...
plzz help me

@dinesh-gadri
Copy link

how to delete row in recycle view when click on delete than that row is delete..plzzz help me

@mayooresan
Copy link

@demil133 after adding android:clickable="true" to the parent element for the item's layout in xml, it started to work. Hope it'll help someone out there.

@dima925
Copy link

dima925 commented Mar 14, 2016

Good sample. it's well for my app.

@shubham08gupta
Copy link

it works !!!

@MansoorJafari
Copy link

Hi
I have a recycler view with event onTap Listener and in item row I have a TextView that have click listener event
in my code OnTap only work. mean after click textview event onTap run and textview event dont work.

please help for solve this problem.

Thanks.

@pradeepkumarreddyk
Copy link

where did you add touch feedback to item layout

@EliudNjuguna
Copy link

How do you implement onClickListener on GridLayout using the RecyclerView

@devmike01
Copy link

This code doesn't work, but this does work

@MinaGabriel
Copy link

the base class doesn't have any on click method???

@SkymanOne
Copy link

SkymanOne commented Dec 6, 2016

but can use int item instead of String item and it's easier work with items

@JSila
Copy link

JSila commented Feb 15, 2017

getPosition is deprecated, use getAdapterPosition instead.

@ayetolusamuel
Copy link

thanks, this save me from item clicklistener mess.
Though this is what i use...
int itemPosition = getLayoutPosition();
Products products = productsArrayList.get(itemPosition);
Thanks for the clue

@ax-vasquez
Copy link

👍 👍 👍 👍

Thanks! This is by far the cleanest solution I have seen for this. Helped a lot!

@deweysia
Copy link

Short and concise. Thanks!

@imrankhanissm
Copy link

Thanks

@parthdesai1208
Copy link

thanks for the code, you saved my lot of time.

@JaiMistry
Copy link

how to get startactivity in onclick()

v.getContext().startActivity(activityIntent);

@IrshadKasana
Copy link

how to implement onItemClickListener on individual items/icons of viewHolder in a recyclerView and perform actions on them inside fragment/activity, but not inside the adapter

@Zhuinden
Copy link

You should not couple your ViewHolders and ItemClickListeners. Please see a better solution here.

how is this better? You don't need a gesture detector to handle clicks.

Just set a setOnClickListener(). The original gist is significantly better than what you linked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment