Skip to content

Instantly share code, notes, and snippets.

@hiroyuki-sato
Created February 16, 2021 13:58
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save hiroyuki-sato/6d6ff00c60b2093d165980d4a8039cf5 to your computer and use it in GitHub Desktop.
Save hiroyuki-sato/6d6ff00c60b2093d165980d4a8039cf5 to your computer and use it in GitHub Desktop.
embulk-filter-flatten_json patch
diff --git a/src/main/java/org/embulk/filter/flatten_json/FlattenJsonFilterPlugin.java b/src/main/java/org/embulk/filter/flatten_json/FlattenJsonFilterPlugin.java
index 8caaf97..7898bc5 100644
--- a/src/main/java/org/embulk/filter/flatten_json/FlattenJsonFilterPlugin.java
+++ b/src/main/java/org/embulk/filter/flatten_json/FlattenJsonFilterPlugin.java
@@ -85,11 +85,12 @@ public class FlattenJsonFilterPlugin
return new PageOutput()
{
private PageReader pageReader = new PageReader(inputSchema);
+ private PageBuilder pageBuilder = new PageBuilder(Exec.getBufferAllocator(), outputSchema, output);
@Override
public void add(Page page)
{
- try (PageBuilder pageBuilder = new PageBuilder(Exec.getBufferAllocator(), outputSchema, output)) {
+ try {
pageReader.setPage(page);
while (pageReader.nextRecord()) {
@@ -97,7 +98,6 @@ public class FlattenJsonFilterPlugin
setFlattenJsonColumns(pageBuilder, flattenJsonColumns, task.getSeparator(), task.getArrayIndexPrefix());
pageBuilder.addRecord();
}
- pageBuilder.finish();
}
catch (IOException e) {
logger.error(e.getMessage());
@@ -108,13 +108,12 @@ public class FlattenJsonFilterPlugin
@Override
public void finish()
{
- output.finish();
+ pageBuilder.finish();
}
@Override
public void close()
{
- pageReader.close();
output.close();
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment