Skip to content

Instantly share code, notes, and snippets.

@ikesyo
Created December 25, 2015 04:22
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save ikesyo/3e208e99e1c301bc237d to your computer and use it in GitHub Desktop.
Save ikesyo/3e208e99e1c301bc237d to your computer and use it in GitHub Desktop.
diff --git a/Source/CarthageKit/Resolver.swift b/Source/CarthageKit/Resolver.swift
index 884880b..4f20925 100644
--- a/Source/CarthageKit/Resolver.swift
+++ b/Source/CarthageKit/Resolver.swift
@@ -117,13 +117,13 @@ public struct Resolver {
private func resolveDependenciesFromNodePermutations(permutationsProducer: SignalProducer<[DependencyNode], CarthageError>) -> SignalProducer<DependencyGraph, CarthageError> {
return permutationsProducer
- .flatMap(.Concat) { rootNodes -> SignalProducer<Event<DependencyGraph, CarthageError>, CarthageError> in
+ .flatMap(.Concat) { rootNodes -> SignalProducer<DependencyGraph, CarthageError> in
return self.graphPermutationsForEachNode(rootNodes, dependencyOf: nil, basedOnGraph: DependencyGraph())
.promoteErrors(CarthageError.self)
+ // Pass through resolution errors only if we never got
+ // a valid graph.
+ .dematerializeErrorsIfEmpty()
}
- // Pass through resolution errors only if we never got
- // a valid graph.
- .dematerializeErrorsIfEmpty()
.take(1)
.observeOn(QueueScheduler(queue: dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), name: "org.carthage.CarthageKit.Resolver.resolveDependencesInCartfile"))
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment