Skip to content

Instantly share code, notes, and snippets.

@johnynek

johnynek/lint_output.txt

Created September 5, 2018 00:53
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save johnynek/c76dd39f1f51ae02638fd4db327f160c to your computer and use it in GitHub Desktop.
Save johnynek/c76dd39f1f51ae02638fd4db327f160c to your computer and use it in GitHub Desktop.
Download ZIP
lint.sh output in rules scala PR: https://github.com/bazelbuild/rules_scala/pull/601
Raw
lint_output.txt
--- /Users/oscar/oss/rules_scala/scala/private/rule_impls.bzl (original)
+++ /Users/oscar/oss/rules_scala/scala/private/rule_impls.bzl (reformatted)
@@ -99,9 +99,7 @@
outs = [ctx.outputs.jar, ctx.outputs.statsfile]
- inputs = ctx.files.resources + [
- ctx.outputs.manifest, zipper_arg_path
- ]
+ inputs = ctx.files.resources + [ctx.outputs.manifest, zipper_arg_path]
ctx.actions.run_shell(
inputs = inputs,
*.bzl BUILDIFIER ERRORS:
/Users/oscar/oss/rules_scala/test/aspect/aspect.bzl
6c6,10
< attr_aspects = ["_scala_toolchain", "deps"]
---
>
> attr_aspects = [
> "_scala_toolchain",
> "deps",
> ]
76d79
< implementation = _rule_impl,
81a85
> implementation = _rule_impl,
/Users/oscar/oss/rules_scala/tut_rule/tut.bzl
4a5
> _default_scala_version = "default_scala_version",
6,7c7
< _default_scala_version = "default_scala_version")
<
---
> )
10c10,11
< _scala_maven_import_external = "scala_maven_import_external")
---
> _scala_maven_import_external = "scala_maven_import_external",
> )
/Users/oscar/oss/rules_scala/twitter_scrooge/twitter_scrooge.bzl
3d2
< _scala_mvn_artifact = "scala_mvn_artifact",
5,6c4,6
< _extract_major_version = "extract_major_version")
<
---
> _extract_major_version = "extract_major_version",
> _scala_mvn_artifact = "scala_mvn_artifact",
> )
9,13c9,16
< _scala_maven_import_external = "scala_maven_import_external")
<
< load("//scala/private:common.bzl", "write_manifest_file", "collect_srcjars",
< "collect_jars")
<
---
> _scala_maven_import_external = "scala_maven_import_external",
> )
> load(
> "//scala/private:common.bzl",
> "write_manifest_file",
> "collect_srcjars",
> "collect_jars",
> )
15d17
<
17,19c19,23
<
< load("@io_bazel_rules_scala//thrift:thrift.bzl", "merge_thrift_infos",
< "empty_thrift_info")
---
> load(
> "@io_bazel_rules_scala//thrift:thrift.bzl",
> "merge_thrift_infos",
> "empty_thrift_info",
> )
290,291c294
< implementation = _scrooge_aspect_impl,
< attr_aspects = ['deps'],
---
> attr_aspects = ["deps"],
297c300,301
< allow_files = True),
---
> allow_files = True,
> ),
300c304,306
< "@io_bazel_rules_scala//src/java/io/bazel/rulesscala/scalac")),
---
> "@io_bazel_rules_scala//src/java/io/bazel/rulesscala/scalac",
> ),
> ),
305c311
< "//external:io_bazel_rules_scala/dependency/scala/scala_library"
---
> "//external:io_bazel_rules_scala/dependency/scala/scala_library",
308c314
< "//external:io_bazel_rules_scala/dependency/thrift/libthrift"
---
> "//external:io_bazel_rules_scala/dependency/thrift/libthrift",
311c317
< "//external:io_bazel_rules_scala/dependency/thrift/scrooge_core"
---
> "//external:io_bazel_rules_scala/dependency/thrift/scrooge_core",
314c320
< "//external:io_bazel_rules_scala/dependency/thrift/util_core"
---
> "//external:io_bazel_rules_scala/dependency/thrift/util_core",
316c322,323
< ]),
---
> ],
> ),
318,320c325,330
< required_aspect_providers = [[ThriftInfo],
< [ScroogeImport]],
< toolchains = ['@io_bazel_rules_scala//scala:toolchain_type'],
---
> required_aspect_providers = [
> [ThriftInfo],
> [ScroogeImport],
> ],
> toolchains = ["@io_bazel_rules_scala//scala:toolchain_type"],
> implementation = _scrooge_aspect_impl,
343d352
< implementation = _scrooge_scala_library_impl,
345,346c354,355
< 'deps': attr.label_list(aspects = [scrooge_aspect]),
< 'exports': attr.label_list(providers = [JavaInfo]),
---
> "deps": attr.label_list(aspects = [scrooge_aspect]),
> "exports": attr.label_list(providers = [JavaInfo]),
348c357,362
< provides = [DefaultInfo, ScroogeInfo, JavaInfo],
---
> provides = [
> DefaultInfo,
> ScroogeInfo,
> JavaInfo,
> ],
> implementation = _scrooge_scala_library_impl,
383d396
< implementation = _scrooge_scala_import_impl,
391c404
< "//external:io_bazel_rules_scala/dependency/scala/scala_library"
---
> "//external:io_bazel_rules_scala/dependency/scala/scala_library",
394c407
< "//external:io_bazel_rules_scala/dependency/thrift/libthrift"
---
> "//external:io_bazel_rules_scala/dependency/thrift/libthrift",
397c410
< "//external:io_bazel_rules_scala/dependency/thrift/scrooge_core"
---
> "//external:io_bazel_rules_scala/dependency/thrift/scrooge_core",
399c412,413
< ]),
---
> ],
> ),
401c415,421
< provides = [ThriftInfo, JavaInfo, ScroogeImport])
---
> provides = [
> ThriftInfo,
> JavaInfo,
> ScroogeImport,
> ],
> implementation = _scrooge_scala_import_impl,
> )
/Users/oscar/oss/rules_scala/thrift/thrift.bzl
129d128
< implementation = _thrift_library_impl,
147c146,149
< "absolute_prefix": attr.string(default = '', mandatory = False),
---
> "absolute_prefix": attr.string(
> default = "",
> mandatory = False,
> ),
156c158,159
< allow_files = True)
---
> allow_files = True,
> ),
159a163
> implementation = _thrift_library_impl,
/Users/oscar/oss/rules_scala/scala/scala_cross_version.bzl
16c16,18
< _scala_maven_import_external = "scala_maven_import_external")
---
> _scala_maven_import_external = "scala_maven_import_external",
> )
>
/Users/oscar/oss/rules_scala/scala/scala_toolchain.bzl
3c3,4
< _ScalacProvider = "ScalacProvider")
---
> _ScalacProvider = "ScalacProvider",
> )
15,16c16,17
< 'scalacopts': attr.string_list(),
< 'scalac_provider_attr': attr.label(
---
> "scalacopts": attr.string_list(),
> "scalac_provider_attr": attr.label(
18,21c19,30
< providers = [_ScalacProvider]),
< 'unused_dependency_checker_mode': attr.string(
< default = "off", values = ["off", "warn", "error"]),
< })
---
> providers = [_ScalacProvider],
> ),
> "unused_dependency_checker_mode": attr.string(
> default = "off",
> values = [
> "off",
> "warn",
> "error",
> ],
> ),
> },
> )
/Users/oscar/oss/rules_scala/scala/scala.bzl
3c3,4
< _scala_library_impl = "scala_library_impl",
---
> _scala_binary_impl = "scala_binary_impl",
> _scala_junit_test_impl = "scala_junit_test_impl",
5c6,7
< "scala_library_for_plugin_bootstrapping_impl",
---
> "scala_library_for_plugin_bootstrapping_impl",
> _scala_library_impl = "scala_library_impl",
7,8d8
< _scala_binary_impl = "scala_binary_impl",
< _scala_test_impl = "scala_test_impl",
10c10
< _scala_junit_test_impl = "scala_junit_test_impl",
---
> _scala_test_impl = "scala_test_impl",
12d11
<
14d12
<
17,18c15,16
< _scala_maven_import_external = "scala_maven_import_external")
<
---
> _scala_maven_import_external = "scala_maven_import_external",
> )
23d20
<
26,27d22
< _new_scala_default_repository = "new_scala_default_repository",
< _extract_major_version = "extract_major_version",
29,30c24,27
< _default_scala_version_jar_shas = "default_scala_version_jar_shas")
<
---
> _default_scala_version_jar_shas = "default_scala_version_jar_shas",
> _extract_major_version = "extract_major_version",
> _new_scala_default_repository = "new_scala_default_repository",
> )
33,34c30,31
< _specs2_junit_dependencies = "specs2_junit_dependencies")
<
---
> _specs2_junit_dependencies = "specs2_junit_dependencies",
> )
37c34,35
< _scala_import = "scala_import")
---
> _scala_import = "scala_import",
> )
41c39,40
< default = Label("@java_stub_template//file")),
---
> default = Label("@java_stub_template//file"),
> ),
49c48,49
< allow_files = True),
---
> allow_files = True,
> ),
54c54,55
< allow_files = True),
---
> allow_files = True,
> ),
56c57,58
< default = Label("@bazel_tools//tools/jdk:current_java_toolchain")),
---
> default = Label("@bazel_tools//tools/jdk:current_java_toolchain"),
> ),
59c61,62
< cfg = "host"),
---
> cfg = "host",
> ),
61c64,65
< default = Label("@bazel_tools//tools/jdk:current_java_runtime")),
---
> default = Label("@bazel_tools//tools/jdk:current_java_runtime"),
> ),
64c68,70
< "@io_bazel_rules_scala//src/java/io/bazel/rulesscala/scalac")),
---
> "@io_bazel_rules_scala//src/java/io/bazel/rulesscala/scalac",
> ),
> ),
72c78
< "//external:io_bazel_rules_scala/dependency/scala/scala_library"
---
> "//external:io_bazel_rules_scala/dependency/scala/scala_library",
75c81,82
< allow_files = False),
---
> allow_files = False,
> ),
82c89
< "//external:io_bazel_rules_scala/dependency/scala/scala_library"
---
> "//external:io_bazel_rules_scala/dependency/scala/scala_library",
85c92
< "//external:io_bazel_rules_scala/dependency/scalatest/scalatest"
---
> "//external:io_bazel_rules_scala/dependency/scalatest/scalatest",
88c95,96
< allow_files = False),
---
> allow_files = False,
> ),
95c103
< "//external:io_bazel_rules_scala/dependency/scala/scala_library"
---
> "//external:io_bazel_rules_scala/dependency/scala/scala_library",
99c107
< "//external:io_bazel_rules_scala/dependency/hamcrest/hamcrest_core"
---
> "//external:io_bazel_rules_scala/dependency/hamcrest/hamcrest_core",
102c110,111
< allow_files = False),
---
> allow_files = False,
> ),
107c116,120
< "srcs": attr.label_list(allow_files = [".scala", ".srcjar", ".java"]),
---
> "srcs": attr.label_list(allow_files = [
> ".scala",
> ".srcjar",
> ".java",
> ]),
120,121c133,140
< "expect_java_output": attr.bool(default = True, mandatory = False),
< "print_compile_time": attr.bool(default = False, mandatory = False),
---
> "expect_java_output": attr.bool(
> default = True,
> mandatory = False,
> ),
> "print_compile_time": attr.bool(
> default = False,
> mandatory = False,
> ),
124a144
>
125a146
>
132c153
< "@io_bazel_rules_scala//third_party/dependency_analyzer/src/main:dependency_analyzer"
---
> "@io_bazel_rules_scala//third_party/dependency_analyzer/src/main:dependency_analyzer",
135c156,157
< mandatory = False),
---
> mandatory = False,
> ),
137c159,164
< values = ["warn", "error", "off", ""],
---
> values = [
> "warn",
> "error",
> "off",
> "",
> ],
142c169
< "@io_bazel_rules_scala//third_party/unused_dependency_checker/src/main:unused_dependency_checker"
---
> "@io_bazel_rules_scala//third_party/unused_dependency_checker/src/main:unused_dependency_checker",
145c172,173
< mandatory = False),
---
> mandatory = False,
> ),
161a190
>
164a194
>
165a196
>
166a198
>
167a200
>
171d203
< implementation = _scala_library_impl,
173d204
< outputs = _library_outputs,
175c206,208
< toolchains = ['@io_bazel_rules_scala//scala:toolchain_type'],
---
> outputs = _library_outputs,
> toolchains = ["@io_bazel_rules_scala//scala:toolchain_type"],
> implementation = _scala_library_impl,
181a215
>
182a217
>
183a219
>
184a221
>
186c223,225
< _common_attrs_for_plugin_bootstrapping)
---
> _common_attrs_for_plugin_bootstrapping,
> )
>
188d226
< implementation = _scala_library_for_plugin_bootstrapping_impl,
190d227
< outputs = _library_outputs,
192c229,231
< toolchains = ['@io_bazel_rules_scala//scala:toolchain_type'],
---
> outputs = _library_outputs,
> toolchains = ["@io_bazel_rules_scala//scala:toolchain_type"],
> implementation = _scala_library_for_plugin_bootstrapping_impl,
198a238
>
199a240
>
200a242
>
201a244
>
202a246
>
206c250,255
< values = ["warn", "error", "off", ""],
---
> values = [
> "warn",
> "error",
> "off",
> "",
> ],
211d259
< implementation = _scala_macro_library_impl,
213d260
< outputs = _common_outputs,
215c262,264
< toolchains = ['@io_bazel_rules_scala//scala:toolchain_type'],
---
> outputs = _common_outputs,
> toolchains = ["@io_bazel_rules_scala//scala:toolchain_type"],
> implementation = _scala_macro_library_impl,
221a271
>
222a273
>
223a275
>
224a277
>
225a279
>
227d280
< implementation = _scala_binary_impl,
229d281
< outputs = _common_outputs,
232c284,286
< toolchains = ['@io_bazel_rules_scala//scala:toolchain_type'],
---
> outputs = _common_outputs,
> toolchains = ["@io_bazel_rules_scala//scala:toolchain_type"],
> implementation = _scala_binary_impl,
237c291,292
< default = "io.bazel.rulesscala.scala_test.Runner"),
---
> default = "io.bazel.rulesscala.scala_test.Runner",
> ),
243c298,300
< "//external:io_bazel_rules_scala/dependency/scalatest/scalatest")),
---
> "//external:io_bazel_rules_scala/dependency/scalatest/scalatest",
> ),
> ),
246c303,304
< default = Label("//src/java/io/bazel/rulesscala/scala_test:runner")),
---
> default = Label("//src/java/io/bazel/rulesscala/scala_test:runner"),
> ),
248c306,307
< default = Label("//scala/support:test_reporter")),
---
> default = Label("//scala/support:test_reporter"),
> ),
249a309
>
250a311
>
251a313
>
252a315
>
253a317
>
255d318
< implementation = _scala_test_impl,
257d319
< outputs = _common_outputs,
259d320
< test = True,
261c322,325
< toolchains = ['@io_bazel_rules_scala//scala:toolchain_type'],
---
> outputs = _common_outputs,
> test = True,
> toolchains = ["@io_bazel_rules_scala//scala:toolchain_type"],
> implementation = _scala_test_impl,
264a329
>
265a331
>
266a333
>
267a335
>
268a337
>
270d338
< implementation = _scala_repl_impl,
272d339
< outputs = _common_outputs,
275c342,344
< toolchains = ['@io_bazel_rules_scala//scala:toolchain_type'],
---
> outputs = _common_outputs,
> toolchains = ["@io_bazel_rules_scala//scala:toolchain_type"],
> implementation = _scala_repl_impl,
500c569,571
< "//src/java/io/bazel/rulesscala/test_discovery:test_discovery")),
---
> "//src/java/io/bazel/rulesscala/test_discovery:test_discovery",
> ),
> ),
502,503c573,578
< default = "io.bazel.rulesscala.test_discovery.DiscoveredTestSuite"),
< "print_discovered_classes": attr.bool(default = False, mandatory = False),
---
> default = "io.bazel.rulesscala.test_discovery.DiscoveredTestSuite",
> ),
> "print_discovered_classes": attr.bool(
> default = False,
> mandatory = False,
> ),
506c581,583
< "//external:io_bazel_rules_scala/dependency/junit/junit")),
---
> "//external:io_bazel_rules_scala/dependency/junit/junit",
> ),
> ),
509c586,587
< "//external:io_bazel_rules_scala/dependency/hamcrest/hamcrest_core")
---
> "//external:io_bazel_rules_scala/dependency/hamcrest/hamcrest_core",
> ),
513,514c591,594
< "@io_bazel_rules_scala//scala:bazel_test_runner_deploy"),
< allow_files = True),
---
> "@io_bazel_rules_scala//scala:bazel_test_runner_deploy",
> ),
> allow_files = True,
> ),
515a596
>
516a598
>
517a600
>
518a602
>
519a604
>
521d605
< implementation = _scala_junit_test_impl,
522a607
> fragments = ["java"],
525,526c610,612
< fragments = ["java"],
< toolchains = ['@io_bazel_rules_scala//scala:toolchain_type'])
---
> toolchains = ["@io_bazel_rules_scala//scala:toolchain_type"],
> implementation = _scala_junit_test_impl,
> )
/Users/oscar/oss/rules_scala/scala/scala_import.bzl
120d119
< implementation = _scala_import_impl,
135a135
> implementation = _scala_import_impl,
/Users/oscar/oss/rules_scala/scala/private/rule_impls.bzl
14a15
>
19c20,21
< _ScalacProvider = "ScalacProvider")
---
> _ScalacProvider = "ScalacProvider",
> )
32a35
>
33a37
>
/Users/oscar/oss/rules_scala/scala/scala_maven_import_external.bzl
38a39
>
164d164
< implementation = _jvm_import_external,
167,168c167,174
< "licenses": attr.string_list(mandatory = True, allow_empty = False),
< "jar_urls": attr.string_list(mandatory = True, allow_empty = False),
---
> "licenses": attr.string_list(
> mandatory = True,
> allow_empty = False,
> ),
> "jar_urls": attr.string_list(
> mandatory = True,
> allow_empty = False,
> ),
182c188,189
< default = ["//visibility:public"]),
---
> default = ["//visibility:public"],
> ),
184c191,193
< })
---
> },
> implementation = _jvm_import_external,
> )
/Users/oscar/oss/rules_scala/scala/providers.bzl
34c34,35
< ])
---
> ],
> )
46d46
< implementation = _declare_scalac_provider,
51c51,53
< })
---
> },
> implementation = _declare_scalac_provider,
> )
/Users/oscar/oss/rules_scala/specs2/specs2.bzl
3d2
< _scala_mvn_artifact = "scala_mvn_artifact",
5,6c4,6
< _extract_major_version = "extract_major_version")
<
---
> _extract_major_version = "extract_major_version",
> _scala_mvn_artifact = "scala_mvn_artifact",
> )
9c9,10
< _scala_maven_import_external = "scala_maven_import_external")
---
> _scala_maven_import_external = "scala_maven_import_external",
> )
/Users/oscar/oss/rules_scala/specs2/specs2_junit.bzl
1,3c1,6
< load("//specs2:specs2.bzl", "specs2_repositories", "specs2_dependencies",
< "specs2_version")
<
---
> load(
> "//specs2:specs2.bzl",
> "specs2_repositories",
> "specs2_dependencies",
> "specs2_version",
> )
5d7
<
8d9
< _scala_mvn_artifact = "scala_mvn_artifact",
10,11c11,13
< _extract_major_version = "extract_major_version")
<
---
> _extract_major_version = "extract_major_version",
> _scala_mvn_artifact = "scala_mvn_artifact",
> )
14c16,17
< _scala_maven_import_external = "scala_maven_import_external")
---
> _scala_maven_import_external = "scala_maven_import_external",
> )
/Users/oscar/oss/rules_scala/test_expect_failure/missing_direct_deps/internal_deps/custom-jvm-rule.bzl
19d18
< implementation = _custom_jvm_impl,
22a22
> implementation = _custom_jvm_impl,
/Users/oscar/oss/rules_scala/jmh/jmh.bzl
88d87
< implementation = _scala_generate_benchmark,
90c89,92
< "src": attr.label(allow_single_file = True, mandatory = True),
---
> "src": attr.label(
> allow_single_file = True,
> mandatory = True,
> ),
92c94,96
< default = 'reflection', mandatory = False),
---
> default = "reflection",
> mandatory = False,
> ),
97,98c101,103
< "//src/scala/io/bazel/rules_scala/jmh_support:benchmark_generator"
< ))
---
> "//src/scala/io/bazel/rules_scala/jmh_support:benchmark_generator",
> ),
> ),
103a109
> implementation = _scala_generate_benchmark,
/Users/oscar/oss/rules_scala/scala_proto/scala_proto.bzl
5d4
<
8,9d6
< _scala_mvn_artifact = "scala_mvn_artifact",
< _extract_major_version = "extract_major_version",
10a8,9
> _extract_major_version = "extract_major_version",
> _scala_mvn_artifact = "scala_mvn_artifact",
12d10
<
15,16c13,14
< _scala_maven_import_external = "scala_maven_import_external")
<
---
> _scala_maven_import_external = "scala_maven_import_external",
> )
406,408c404,409
< "proto_library", "java_proto_library", "java_library",
< "scala_library"
< ]),
---
> "proto_library",
> "java_proto_library",
> "java_library",
> "scala_library",
> ],
> ),
411c412,415
< executable = True, cfg = "host", allow_files = True),
---
> executable = True,
> cfg = "host",
> allow_files = True,
> ),
444a449
>
/Users/oscar/oss/rules_scala/src/java/io/bazel/rulesscala/scalac/jvm_export_toolchain.bzl
3c3,4
< _ScalacProvider = "ScalacProvider")
---
> _ScalacProvider = "ScalacProvider",
> )
26c27,28
< toolchains = ['@io_bazel_rules_scala//scala:toolchain_type'])
---
> toolchains = ["@io_bazel_rules_scala//scala:toolchain_type"],
> )
(buildifier on *.bzl files: not enforced)
/Users/oscar/oss/rules_scala/test/check_statsfile.bzl:1:1-2:1: file has no module docstring [missing-module-docstring]
/Users/oscar/oss/rules_scala/test/check_statsfile.bzl:1:1-2:2: function 'check_statsfile' has no docstring (if this function is intended to be private, the name should start with an underscore: '_check_statsfile') [missing-function-docstring]
/Users/oscar/oss/rules_scala/test/aspect/aspect.bzl:2:1-2:79: bad docstring format: the one-line summary should be followed by a blank line [bad-docstring-format]
/Users/oscar/oss/rules_scala/test/src/main/scala/scalarules/test/large_classpath/helper.bzl:1:1-2:1: file has no module docstring [missing-module-docstring]
/Users/oscar/oss/rules_scala/tut_rule/tut.bzl:1:1-2:1: file has no module docstring [missing-module-docstring]
/Users/oscar/oss/rules_scala/tut_rule/tut.bzl:38:1-39:2: function 'scala_tut_doc' has no docstring (if this function is intended to be private, the name should start with an underscore: '_scala_tut_doc') [missing-function-docstring]
/Users/oscar/oss/rules_scala/twitter_scrooge/twitter_scrooge.bzl:1:1-2:1: file has no module docstring [missing-module-docstring]
/Users/oscar/oss/rules_scala/twitter_scrooge/twitter_scrooge.bzl:11:59-11:75: unused binding of 'collect_srcjars'. If you want to re-export a symbol, use the following pattern:
load(..., _collect_srcjars = 'collect_srcjars', ...)
collect_srcjars = _collect_srcjars
More details in the documentation. [unused-binding]
/Users/oscar/oss/rules_scala/twitter_scrooge/twitter_scrooge.bzl:12:6-12:19: unused binding of 'collect_jars'. If you want to re-export a symbol, use the following pattern:
load(..., _collect_jars = 'collect_jars', ...)
collect_jars = _collect_jars
More details in the documentation. [unused-binding]
/Users/oscar/oss/rules_scala/twitter_scrooge/twitter_scrooge.bzl:19:6-19:24: unused binding of 'empty_thrift_info'. If you want to re-export a symbol, use the following pattern:
load(..., _empty_thrift_info = 'empty_thrift_info', ...)
empty_thrift_info = _empty_thrift_info
More details in the documentation. [unused-binding]
/Users/oscar/oss/rules_scala/twitter_scrooge/twitter_scrooge.bzl:21:1-21:14: unused binding of '_jar_extension' [unused-binding]
/Users/oscar/oss/rules_scala/twitter_scrooge/twitter_scrooge.bzl:23:1-25:2: function 'twitter_scrooge' has no docstring (if this function is intended to be private, the name should start with an underscore: '_twitter_scrooge') [missing-function-docstring]
/Users/oscar/oss/rules_scala/twitter_scrooge/twitter_scrooge.bzl:122:1-122:13: provider name 'ScroogeImport' should end in the suffix 'Info' [provider-name-suffix]
/Users/oscar/oss/rules_scala/junit/junit.bzl:1:1-2:1: file has no module docstring [missing-module-docstring]
/Users/oscar/oss/rules_scala/thrift/thrift_info.bzl:1:1-2:1: file has no module docstring [missing-module-docstring]
/Users/oscar/oss/rules_scala/thrift/thrift.bzl:56:7-56:19: unused binding of 'actual_prefix'. If this is intentional, you can use '_' or rename it to '_actual_prefix'. [unused-binding]
/Users/oscar/oss/rules_scala/private/format.bzl:51:1-52:2: function 'format_repositories' has no docstring (if this function is intended to be private, the name should start with an underscore: '_format_repositories') [missing-function-docstring]
/Users/oscar/oss/rules_scala/scala/scala_cross_version.bzl:1:1-2:1: file has no module docstring [missing-module-docstring]
/Users/oscar/oss/rules_scala/scala/scala_cross_version.bzl:17:1-19:14: expression result not used [no-effect]
/Users/oscar/oss/rules_scala/scala/scala_cross_version.bzl:37:3-38:30: incomplete docstring: the return value is not documented (no 'Returns:' section found) [inconsistent-docstring]
/Users/oscar/oss/rules_scala/scala/scala_cross_version.bzl:37:3-38:30: incomplete docstring: the function parameters are not documented (no 'Args:' section found)
The parameter documentation should look like this:
Args:
scala_version: ...
[inconsistent-docstring]
/Users/oscar/oss/rules_scala/scala/scala_cross_version.bzl:38:1-38:27: bad docstring format: closing docstring quote should be on its own line, indented the same as the opening quote [bad-docstring-format]
/Users/oscar/oss/rules_scala/scala/scala_cross_version.bzl:38:1-38:27: bad docstring format: the one-line summary should be followed by a blank line [bad-docstring-format]
/Users/oscar/oss/rules_scala/scala/scala_toolchain.bzl:1:1-2:1: file has no module docstring [missing-module-docstring]
/Users/oscar/oss/rules_scala/scala/scala.bzl:1:1-2:1: file has no module docstring [missing-module-docstring]
/Users/oscar/oss/rules_scala/scala/scala.bzl:21:5-21:19: unused binding of '_ScalacProvider' [unused-binding]
/Users/oscar/oss/rules_scala/scala/scala.bzl:37:5-37:17: unused binding of '_scala_import' [unused-binding]
/Users/oscar/oss/rules_scala/scala/scala.bzl:278:1-282:2: function 'scala_repositories' has no docstring (if this function is intended to be private, the name should start with an underscore: '_scala_repositories') [missing-function-docstring]
/Users/oscar/oss/rules_scala/scala/scala.bzl:429:22-429:30: unused binding of 'data'. If this is intentional, you can add `_ignore = [<param1>, <param2>, ...]` to the function body. [unused-binding]
/Users/oscar/oss/rules_scala/scala/scala_import.bzl:1:1-2:1: file has no module docstring [missing-module-docstring]
/Users/oscar/oss/rules_scala/scala/jars_to_labels.bzl:1:1-2:1: file has no module docstring [missing-module-docstring]
/Users/oscar/oss/rules_scala/scala/private/rule_impls.bzl:15:58-15:74: unused binding of 'scala_toolchain'. If you want to re-export a symbol, use the following pattern:
load(..., _scala_toolchain = 'scala_toolchain', ...)
scala_toolchain = _scala_toolchain
More details in the documentation. [unused-binding]
/Users/oscar/oss/rules_scala/scala/private/rule_impls.bzl:26:5-26:24: unused binding of 'filter_not_sources'. If you want to re-export a symbol, use the following pattern:
load(..., _filter_not_sources = 'filter_not_sources', ...)
filter_not_sources = _filter_not_sources
More details in the documentation. [unused-binding]
/Users/oscar/oss/rules_scala/scala/private/rule_impls.bzl:135:1-157:2: function 'compile_scala' has no docstring (if this function is intended to be private, the name should start with an underscore: '_compile_scala') [missing-function-docstring]
/Users/oscar/oss/rules_scala/scala/private/rule_impls.bzl:317:1-319:2: function 'try_to_compile_java_jar' has no docstring (if this function is intended to be private, the name should start with an underscore: '_try_to_compile_java_jar') [missing-function-docstring]
/Users/oscar/oss/rules_scala/scala/private/rule_impls.bzl:479:3-480:43: incomplete docstring: the return value is not documented (no 'Returns:' section found) [inconsistent-docstring]
/Users/oscar/oss/rules_scala/scala/private/rule_impls.bzl:479:3-480:43: incomplete docstring: the function parameters are not documented (no 'Args:' section found)
The parameter documentation should look like this:
Args:
ctx: ...
args: ...
wrapper_preamble: ...
[inconsistent-docstring]
/Users/oscar/oss/rules_scala/scala/private/rule_impls.bzl:480:1-480:40: bad docstring format: closing docstring quote should be on its own line, indented the same as the opening quote [bad-docstring-format]
/Users/oscar/oss/rules_scala/scala/private/rule_impls.bzl:480:1-480:40: bad docstring format: the one-line summary should be followed by a blank line [bad-docstring-format]
/Users/oscar/oss/rules_scala/scala/private/rule_impls.bzl:545:1-551:15: some but not all execution paths of 'is_dependency_analyzer_on' return a value. If it is intentional, make it explicit using 'return None'. If you know these cannot happen, add the statement `fail('unreachable')` to them. For more details, have a look at the documentation. [missing-return-value]
/Users/oscar/oss/rules_scala/scala/private/rule_impls.bzl:743:1-744:2: function 'scala_binary_impl' has no docstring (if this function is intended to be private, the name should start with an underscore: '_scala_binary_impl') [missing-function-docstring]
/Users/oscar/oss/rules_scala/scala/private/rule_impls.bzl:775:1-776:2: function 'scala_repl_impl' has no docstring (if this function is intended to be private, the name should start with an underscore: '_scala_repl_impl') [missing-function-docstring]
/Users/oscar/oss/rules_scala/scala/private/rule_impls.bzl:839:1-840:2: function 'scala_test_impl' has no docstring (if this function is intended to be private, the name should start with an underscore: '_scala_test_impl') [missing-function-docstring]
/Users/oscar/oss/rules_scala/scala/private/rule_impls.bzl:927:1-928:2: function 'scala_junit_test_impl' has no docstring (if this function is intended to be private, the name should start with an underscore: '_scala_junit_test_impl') [missing-function-docstring]
/Users/oscar/oss/rules_scala/scala/private/rule_impls.bzl:973:3-973:18: identifier 'launcherJvmFlags' should be lower_snake_case (for variables) or UPPER_SNAKE_CASE (for constants) [name-with-wrong-case]
/Users/oscar/oss/rules_scala/scala/private/common.bzl:1:1-2:1: file has no module docstring [missing-module-docstring]
/Users/oscar/oss/rules_scala/scala/scala_maven_import_external.bzl:15:1-15:81: bad docstring format: the one-line summary should be followed by a blank line [bad-docstring-format]
/Users/oscar/oss/rules_scala/scala/scala_maven_import_external.bzl:210:1-364:3: expression result not used [no-effect]
/Users/oscar/oss/rules_scala/scala/providers.bzl:1:1-2:1: file has no module docstring [missing-module-docstring]
/Users/oscar/oss/rules_scala/scala/providers.bzl:28:1-28:14: provider name 'ScalacProvider' should end in the suffix 'Info' [provider-name-suffix]
/Users/oscar/oss/rules_scala/scala/toolchains.bzl:1:1-2:1: file has no module docstring [missing-module-docstring]
/Users/oscar/oss/rules_scala/specs2/specs2.bzl:1:1-2:1: file has no module docstring [missing-module-docstring]
/Users/oscar/oss/rules_scala/specs2/specs2.bzl:14:1-16:2: function 'specs2_repositories' has no docstring (if this function is intended to be private, the name should start with an underscore: '_specs2_repositories') [missing-function-docstring]
/Users/oscar/oss/rules_scala/specs2/specs2_junit.bzl:1:1-2:1: file has no module docstring [missing-module-docstring]
/Users/oscar/oss/rules_scala/specs2/specs2_junit.bzl:16:1-19:2: function 'specs2_junit_repositories' has no docstring (if this function is intended to be private, the name should start with an underscore: '_specs2_junit_repositories') [missing-function-docstring]
/Users/oscar/oss/rules_scala/test_expect_failure/missing_direct_deps/internal_deps/custom-jvm-rule.bzl:1:1-2:1: file has no module docstring [missing-module-docstring]
/Users/oscar/oss/rules_scala/test_expect_failure/missing_direct_deps/internal_deps/custom-jvm-rule.bzl:15:5-15:80: '+' operator is deprecated and should not be used on depsets [deprecated-plus-depset]
/Users/oscar/oss/rules_scala/jmh/jmh.bzl:1:1-2:1: file has no module docstring [missing-module-docstring]
/Users/oscar/oss/rules_scala/jmh/jmh.bzl:3:1-4:2: function 'jmh_repositories' has no docstring (if this function is intended to be private, the name should start with an underscore: '_jmh_repositories') [missing-function-docstring]
/Users/oscar/oss/rules_scala/jmh/jmh.bzl:106:1-107:2: function 'scala_benchmark_jmh' has no docstring (if this function is intended to be private, the name should start with an underscore: '_scala_benchmark_jmh') [missing-function-docstring]
/Users/oscar/oss/rules_scala/scala_proto/scala_proto.bzl:1:1-2:1: file has no module docstring [missing-module-docstring]
/Users/oscar/oss/rules_scala/scala_proto/scala_proto.bzl:23:1-26:2: function 'scala_proto_repositories' has no docstring (if this function is intended to be private, the name should start with an underscore: '_scala_proto_repositories') [missing-function-docstring]
/Users/oscar/oss/rules_scala/scala_proto/scala_proto.bzl:467:1-475:2: function 'scalapb_proto_library' has no docstring (if this function is intended to be private, the name should start with an underscore: '_scalapb_proto_library') [missing-function-docstring]
/Users/oscar/oss/rules_scala/src/java/io/bazel/rulesscala/scalac/jvm_export_toolchain.bzl:1:1-2:1: file has no module docstring [missing-module-docstring]
============ SUMMARY ============
skylark Failure
python Ok
bazel Ok
java Ok
skylint Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment