Skip to content

Instantly share code, notes, and snippets.

What would you like to do?
Drupal 9 compatibility drupalci-.yml
# This file customizes the steps that DrupalCI will use when testing this project.
# The primary customization provided here is to check for deprecation errors. It is recommended
# to do this only when you've used to verify any
# existing deprecation errors are addressed.
# Learn to make one for your own project:
# phpcs will use core's specified version of Coder.
sniff-all-files: true
halt-on-fail: false
# run_tests task is executed several times in order of performance speeds.
# halt-on-fail can be set on the run_tests tasks in order to fail fast.
# suppress-deprecations is false in order to be alerted to usages of
# deprecated code.
types: 'Simpletest,PHPUnit-Unit,PHPUnit-Kernel,PHPUnit-Functional'
testgroups: '--all'
suppress-deprecations: false
types: 'PHPUnit-FunctionalJavascript'
testgroups: '--all'
suppress-deprecations: false
nightwatchjs: { }
Copy link

heddn commented Apr 10, 2019

Also, based on conversation in Slack, adding suppress-deprecations: false to drupalci.yml files right is not encouraged. It takes a lot of system resources and would run on every patch. So adding it to every contrib project would drastically increase the budget for testbots.

Copy link

alexpott commented Apr 11, 2019

@heddn I don't think suppress-deprecations: false is expensive. It's if you turn on the drupal-check implementation - i.e. you enable phpstan code checking.

Copy link

webchick commented Apr 11, 2019

I think the point made (by @goba) was that suddenly turning DrupalCI on for thousands of new projects (if we ask sprinters to add patches for the "known good" modules) would be the resource hog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment