juliandescottes

First, let's look at all the call sites that don't reassign/rename anything.

StyleRuleFront::get href()

Could be replaced be returning parentStylesheet.href in the actor's form.

StyleRuleFront::get nodeHref()

Same comment as for href().

juliandescottes

Wep Platform Tests

Update metadata

./mach wpt-update /Users/jdescottes/Development/wpt-update/

After downloading the relevant wpt-report.json files from try. Always try to take a variety of platforms (eg 1 linux 1 android, or more generally one which fails for specific conditions and a successful one).

View WPT tests differences

juliandescottes

{
  "devtools_tests": [
    {
      "test": "devtools/client/memory/test/xpcshell/test_individuals_05.js",
      "averageRuntime": 174.97391418277104,
      "runs": 3193
    },
    {
      "test": "devtools/client/debugger/test/mochitest/browser_dbg-sourcemapped-scopes.js",
      "averageRuntime": 174.76304804804806,

juliandescottes

Main Process (pid 89180)
Explicit Allocations

1.05 MB (100.0%) -- explicit
├──0.98 MB (93.50%) -- images
│  ├──0.84 MB (80.26%) -- chrome/vector/used/progress=18f
│  │  ├──0.06 MB (05.55%) -- image(5x7, chrome://devtools/skin/images/breadcrumbs-divider.svg)
│  │  │  ├──0.05 MB (05.15%) ── source
│  │  │  └──0.00 MB (00.41%) ++ locked/types=2000/surface(5x7)
│  │  ├──0.05 MB (05.00%) -- image(16x16, chrome://devtools/skin/images/close-3-pane.svg)

juliandescottes

                                                                ┌────────────────────────────┐                                         
 ╔═════════════════════════════════════╗                        │ domainA page               │                                         
 ║                                     ║                        │                            │                                         
 ║    LISTING REMOTE FRAMES BEFORE     ║                        │     ┌────────────────────┐ │                                         
 ║                                     ║                        │     │ domainB iframe     │ │                                         
 ╚═════════════════════════════════════╝                        │     │                    │ │                                         
                                                                │     └────────────────────┘ │                                         
                                                                └───

juliandescottes

/Users/jdescottes/Development/hg/fx-team-artifact/devtools/client/aboutdebugging/src/actions/debug-targets.js
  308:30  error  Unexpected `await` inside a loop.  no-await-in-loop (eslint)

/Users/jdescottes/Development/hg/fx-team-artifact/devtools/client/aboutdebugging/src/actions/runtimes.js
  496:9  error  Unexpected `await` inside a loop.  no-await-in-loop (eslint)
  514:9  error  Unexpected `await` inside a loop.  no-await-in-loop (eslint)

/Users/jdescottes/Development/hg/fx-team-artifact/devtools/client/accessibility/accessibility-view.js
  164:24  error  Unexpected `await` inside a loop.  no-await-in-loop (eslint)
  168:13  error  Unexpected `await` inside a loop.  no-await-in-loop (eslint)

juliandescottes

addActorPool@resource://devtools/shared/client/devtools-client.js:772:17
get _poolMap@resource://devtools/shared/protocol/Pool.js:62:15
manage@resource://devtools/shared/protocol/Pool.js:84:5
manage@resource://devtools/shared/protocol/Front.js:89:11
read@resource://devtools/shared/protocol/types.js:346:21
read@resource://devtools/shared/protocol/Response.js:106:22
read@resource://devtools/shared/protocol/Response.js:77:24
generateRequestMethods/</frontProto[name]/<@resource://devtools/shared/protocol/Front/FrontClassWithSpec.js:52:31
promise callback*generateRequestMethods/</frontProto[name]@resource://devtools/shared/protocol/Front/FrontClassWithSpec.js:49:35
enumProperties@resource://devtools/shared/fronts/object.js:156:18

juliandescottes

addActorPool@resource://devtools/shared/client/devtools-client.js:772:17
get _poolMap@resource://devtools/shared/protocol/Pool.js:62:15
manage@resource://devtools/shared/protocol/Pool.js:84:5
manage@resource://devtools/shared/protocol/Front.js:89:11
ObjectFront@resource://devtools/shared/fronts/object.js:31:17
getAdHocFrontOrPrimitiveGrip@resource://devtools/shared/fronts/object.js:345:23
_onResult/<@resource://devtools/shared/fronts/property-iterator.js:54:50
_onResult@resource://devtools/shared/fronts/property-iterator.js:50:42
slice@resource://devtools/shared/fronts/property-iterator.js:33:17
async*iteratorSlice@resource://devtools/client/shared/components/reps/reps.js:4291:19

juliandescottes

Traceback (most recent call last):
  File "/Users/jdescottes/Development/hg/fx-team-artifact/objdir.noindex/_virtualenvs/init_py3/bin/pipenv", line 8, in <module>
    sys.exit(cli())
  File "/Users/jdescottes/Development/hg/fx-team-artifact/objdir.noindex/_virtualenvs/init_py3/lib/python3.7/site-packages/pipenv/vendor/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/Users/jdescottes/Development/hg/fx-team-artifact/objdir.noindex/_virtualenvs/init_py3/lib/python3.7/site-packages/pipenv/vendor/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/Users/jdescottes/Development/hg/fx-team-artifact/objdir.noindex/_virtualenvs/init_py3/lib/python3.7/site-packages/pipenv/vendor/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/jdescottes/Development/hg/fx-team-artifact/objdir.noindex/_virtualenvs/init_py3/lib/python3.7/site-packages/pipenv/vendor/click/core.py", line 895, in invoke

juliandescottes

Inspector initialization

Current mozilla central

constructor

• [A.1] create the inspector store
• [A.2] bind callbacks

init + deferredOpen (they could transparently be merged together)

• [B.1] localize markup (modifies the DOM of the panel)