k-gun

// Rewrite
- if ($shippingInfo && $shippingInfo['cost'] && $this->formatPrice($shippingInfo['cost'] != 0)) {
+ if (isset($shippingInfo['cost']) && $this->formatPrice($shippingInfo['cost']) > 0)

- $order_id = $this->request->get['order_id'];
+ $order_id = (int) $this->request->get['order_id'];

// Refactor
private function formatPrice($number)
{

k-gun

<canvas id="c" width="1024" height="1024">
<script>
// Creds: https://twitter.com/aemkei/status/1378106731386040322
// let cx = c.getContext('2d'), x, y
// for (x = 0; x < 256; x++) {
//   for (y = 0; y < 256; y++) {
//     if ((x ^ y) % 2) {
//       cx.fillRect(x * x, y * y, x, y);
//     }
//   }

k-gun

<?php
// https://github.com/itchyny/gojq#difference-to-jq
$intdiv = fn($x, $y) => ($x - $x % $y) / $y;

// polyfill
if (!function_exists('intdiv')) {
    function intdiv($x, $y) {
        return ($x - $x % $y) / $y;
    }
}

k-gun

// https://betterexplained.com/examples/birthday/birthday.html
function calc(people) {
    let ret = {
        days: 365,
        people: people
    }

    ret.combinations = ret.people * (ret.people - 1) / 2
    ret.chance = (ret.days - 1) / ret.days
    ret.expected = 1 - (ret.chance ** ret.combinations)

k-gun

<?php

if (!function_exists('each')) {
    function each(array &$array) {
        $value = current($array);
        $key = key($array);

        if (is_null($key)) {
            return false;
        }

k-gun

function convert_base(input, fromBase, toBase)
{
    const chars = '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ'

    if (typeof fromBase == 'number') {
        if (fromBase < 2 || fromBase > 62) {
            throw ('Invalid base for from chars, min=2 & max=62')
        }
        fromBase = chars.substr(0, fromBase)

k-gun

class A { protected int $x; }
class AA extends A { protected $x; }
 // -> PHP Fatal error: Type of acme\AA::$ must be int (as in class acme\A)

No var name here "acme\AA::$".

k-gun

$foo = new class() {
    var ?array $a;
    function dump() { var_dump($this->a); }
    function sort() { ksort($this->a); }
};

// E1: Error: Typed property class@anonymous::$a must not be accessed before initialization
$foo->dump();

// E2: TypeError: ksort() expects parameter 1 to be array, null given (should throw E1 cos its an uninitialized property?)

k-gun

Link: https://bugs.php.net/bug.php?id=78859

---

Weird behavior with uninitialized typed properties and __set/__get


Seems calling a constructor is triggering __set magic for uninitialized typed properties. So it does not matter the property is public or private/protected.

I suppose the problem is __set/__get called before __construct when a type is given to a property. Also I if remove __get then I get object(acme\Options)#1 (1) { ["stack"]=> array(1) { ["stack"]=> array(1) { ["one"]=> int(1) } } }.

k-gun

Link: https://bugs.php.net/bug.php?id=78809

---

Uninitialized typed properties

While throwing when try to access to any uninitialized typed property (eg: $o->x == null),
the codes below are just causing notice.

BTW, error message is so weird. We were expecting something like this;