Skip to content

Instantly share code, notes, and snippets.

@lampshade9909

lampshade9909/ZRXv4RFQOrderGuide.ipynb Secret

Forked from PirosB3/VolleyFireGuide.ipynb
Last active April 26, 2023 01:12
Show Gist options
  • Star 2 You must be signed in to star a gist
  • Fork 1 You must be signed in to fork a gist
  • Save lampshade9909/cf16b2aa198e4df8d00702ffd7bf506a to your computer and use it in GitHub Desktop.
Save lampshade9909/cf16b2aa198e4df8d00702ffd7bf506a to your computer and use it in GitHub Desktop.
Download ZIP
Display the source blob
Display the rendered blob
Raw
ZRXv4RFQOrderGuide.ipynb
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
@felixjff
Copy link

For anyone reading this doc in the future, there's a bug in fill_rfq_order and get_order_info. taker amounts are set to maker amounts. In this example it works, cause both taker and maker amounts are the same. If they would differ, the assert tests would fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment