Skip to content

Instantly share code, notes, and snippets.

Avatar

Kunal Marwaha marwahaha

View GitHub Profile
@marwahaha
marwahaha / releasing.md
Last active Dec 13, 2018
Moment release process
View releasing.md
  1. Make sure there are no unmerged PRs or unresolved critical bugs that should be part of the release

All changes should be squash-merged to develop at this point.

The commit description is the PR title. What makes a good Pull Request title?

  • It should start with an identifier, i.e. [bugfix]
  • It has meaningful text describing the code change
  • If applicable, it references a ticket, i.e. (fixes #23)
  1. Run tests on sauce.

As of 2017.11.20, some of the Windows 7 tests and IE8 tests are flaky, we need to investigate.

View moment-2.19.3.md

moment 2.19.3 changelog

Bugfixes

  • #4326 [bugfix] Fix for ReDOS vulnerability (see #4163)

Misc

  • #4289 [misc] Fix spelling and formatting for U.S. for es-us
@marwahaha
marwahaha / moment-gist.py
Last active Mar 2, 2018
make changelog gist for moment
View moment-gist.py
# coding: utf-8
import sys
if len(sys.argv) < 3:
print("Must specify before and after tags. Example: 'python moment-gist.py 2.19.2 2.19.3'")
sys.exit(1)
BEFORE = sys.argv[1]
AFTER = sys.argv[2]
import re
View moment-2.19.4.md

moment 2.19.4 changelog

Bugfixes

  • #4332 [bugfix] Fix weekday verification for UTC and offset days (fixes #4227)
  • #4336 [bugfix] Fix #4334: Remove unused function call argument

Misc

  • #4246 [misc] Add 'ss' relative time key to typescript definition
View moment-2.20.0.md

moment 2.20.0 changelog

Bugfixes

  • #4312 [bugfix] Fix #4251: Avoid RFC2822 in utc() test
  • #4240 [bugfix] Fix incorrect strict parsing with full-width parentheses

Features

  • #4341 [feature] Prevent toISOString converting to UTC (issue #1751)
View moment-2.20.1.md

moment 2.20.1 changelog

Locale improvements

  • #4359 [locale] Fix Arabic locale for months (again)

Misc

  • #4357 [misc] Add optional parameter keepOffset to toISOString
View moment-2.21.0.md

moment 2.21.0 changelog

Bugfixes

  • #4391 [bugfix] Fix #4390: use offset properly in toISOString
  • #4361 [bugfix] remove ordinal for Turkish locale as they use `cardin…
  • #4360 [bugfix] Correct min/max TypeScript signatures
  • #4310 [bugfix] Fix #3883 lazy load parentLocale in defineLocale, fallback to global if missing

New locales

View moment-2.22.0.md

moment 2.22.0 changelog

New locales

  • #4423 [new locale] Added Mongolian locale mn

Locale improvements

  • #4430 [locale] zh-tw: add spaces
  • #4458 [locale] Georgian - fixed incorrectly used word
View moment-2.22.1.md

moment 2.22.1 changelog

Bugfixes

  • #4495 [bugfix] Added HTML5_FMT to moment.d.ts

Locale improvements

  • #3989 [locale] pt: Fix capital letters in weekdays
  • #4478 [locale] ug-cn: put abbr in lowercase
You can’t perform that action at this time.