monfresh

PDF

PAIN

• Code is complicated and takes a long time to understand
• We don't build new features as often as we want
• We have so many bugs that we needed to establish a BAT team to keep track of them. They aren't even getting fixed at the moment. https://martinfowler.com/articles/is-quality-worth-cost.html

DREAM

• Wouldn't it be nice to be able to quickly make changes and add new features?
• Wouldn't it be nice for new team members to jump in to the code faster?

monfresh

Intros

Code Climate guidelines

• If PR is urgent, ask a GitHub repo admin to approve in Code Climate, then immediately fix the offenses. Don't open a new ticket.
• If PR is not urgent, take the time to understand the issue and fix it, unless it's a false positive.
• Walk through reading up on offense in CC

OO principles

Sandi Metz

• https://www.sandimetz.com/blog/2009/06/12/ruby-case-statements-and-kind-of

monfresh

Wisdom Wednesday on Code Quality, March 6, 2019

Moncef's Background:

• Developed interest and focus on code quality and refactoring over past 4 years

• Helped start 18F Development Guide

• Spent lots of time reading and learning

Recommended courses, books, tutorials, newsletters

monfresh

For best results, all forms mentioned below must be printed out, filled out and signed in ink, and mailed directly to OPM at the following address:

U.S. Office of Personnel Management
Attn: Federal Employee Retirement System 
Post Office Box 45
Boyers, PA 16017-0045

In order to send directly to OPM, you must wait 30 days after your last day at GSA. However, because part of the process requires you to mail some forms to your financial institution and wait for them to send them back, you can start the process about 15 days after your last day.

monfresh

notes on installing fish shell

brew install fish

add /usr/local/bin/fish to /etc/shells

chsh -s /usr/local/bin/fish

monfresh

Keybase proof

I hereby claim:

• I am monfresh on github.
• I am monfresh (https://keybase.io/monfresh) on keybase.
• I have a public key whose fingerprint is AFF2 F9F5 3A67 074A 9D56 742F 17D0 259C C64C E075

To claim this, I am signing this object:

monfresh

  def update
    # reset attempt count if user is no longer locked out
    unless resource.otp_time_lockout? || resource.second_factor_locked_at.nil?
      resource.update(second_factor_attempts_count: 0, second_factor_locked_at: nil)
    end

    if resource.authenticate_otp(params[:code].strip)
      warden.session(resource_name)['need_two_factor_authentication'] = false
      sign_in resource_name, resource, bypass: true
      set_flash_message :notice, :success

monfresh

while getopts ":a:o:" opt; do
  case $opt in
    a)
      echo "Getting ready to set environment variables for $2"

      echo "Setting CANONICAL_URL"
      heroku config:set CANONICAL_URL=$2.herokuapp.com --app $2

      echo "Setting DOMAIN_NAME"
      heroku config:set DOMAIN_NAME=herokuapp.com --app $2

monfresh

# Models
class Post < ActiveRecord::Base
  has_many :comments
end

class Comment < ActiveRecord::Base
  belongs_to :post
end

monfresh

# app/models/user.rb
class User
  include Mongoid::Document
  embeds_many :api_applications
  ...
end

# app/models/api_application.rb
class ApiApplication
  include Mongoid::Document