Thanks to Sergey Tihon for running F# Weekly and F# Advent.
Thanks to manofstick for trying out the code and coming with invaluable feedback. Cistern.ValueLinq is very impressive.
There were many interesting improvements in F#6 but one in particular caught my eye, the attribute InlineIfLambda.
The purpose of InlineIfLambda is to instruct the compiler to inline the lambda argument if possible. One reason is potentially improved performance.
Looking at the Array.fs in the F# repository we see that the attribute is used in several places such as in Array.iter:
let inline iter ([<InlineIfLambda>] action) (array: 'T[]) =
checkNonNull "array" array
for i = 0 to array.Length-1 do
action array.[i]Without InlineIfLambda Array.iter would be inlined but invoking action would be a virtual call incurring overhead that sometimes can be important.
// This is an example on what we could write to use Array.iter
let mutable sum = 0
myArray |> Array.iter (fun v -> sum <- sum + v)F#5 also does inlining but it's based on a complexity analysis that we have little control over.
// What above evaluates to in F#5
let sum = ref 0
let action v = sum := !sum + v
// Array.iter inlined
checkNonNull "array" myArray
for i = 0 to myArray.Length-1 do
// But the action is not inlined
action array.[i]So the above code could actually be inlined, or not inlined depending on what the complexity analysis thinks.
// What above evaluates to in F#6
let mutable sum = 0
checkNonNull "array" myArray
for i = 0 to myArray.Length-1 do
sum <- sum + array.[i]This avoids virtual calls as well as allocating a ref cell and a lambda.
Arrays are great but one drawback is that for each step in a pipeline we would create an intermediate array which needs to be garbage collected.
// Creates an array
[|0..10000|]
// Creates a mapped array of ints
|> Array.map ((+) 1)
// Creates a filtered array of ints
|> Array.filter (fun v -> (v &&& 1) = 0)
// Creates a mapped array of longs
|> Array.map int64
// Creates a sum
|> Array.fold (+) 0LOne way around this is using seq
seq { 0..10000 }
|> Seq.map ((+) 1)
|> Seq.filter (fun v -> (v &&& 1) = 0)
|> Seq.map int64
|> Seq.fold (+) 0LIt turns out that the seq pipeline above is about 3x slower than the Array pipeline even if it doesn't allocate (that much) unnecessary memory.
Can we do better?
In a dream world it would be great if we could have a data pipeline with very little overhead for both memory and CPU. Let's try to see what we can do with InlineIfLambda.
seq, which is an alias for IEnumerable<_>, is a so-called pull pipeline. The consumer pulls value through the pipeline by calling MoveNext and Current until MoveNext returns false.
Another approach is to let the producer of data push data through the pipeline. This kind of pipeline tends to be simpler to implement and more performant.
We call it PushStream and as it is essentially nested lambdas InlineIfLambda could help improve performance.
type PushStream<'T> = ('T -> bool) -> boolA PushStream is a function that accepts a receiver function 'T->bool and calls the receiver function until no values are returned or the receiver function returns false indicating it wants no more values. PushStream returns true if the producer values were fully consumed and false if the consumption is stopped before reaching the end of the producer.
A PushStream module could look something like this:
// 'T PushStream is an alternative syntax for PushStream<'T>
type 'T PushStream = ('T -> bool) -> bool
module PushStream =
// Generates a range of ints in b..e
// Note the use of [<InlineIfLambda>] to inline the receiver function r
let inline ofRange b e : int PushStream = fun ([<InlineIfLambda>] r) ->
// This easy to implement in that we loop over the range b..e and
// call the receiver function r until either it returns false
// or we reach the end of the range
// Thanks to InlineIfLambda r should be inlined
let mutable i = b
while i <= e && r i do
i <- i + 1
i > e
// Filters a PushStream using a filter function
// Note the use of [<InlineIfLambda>] to inline both the filter function f and the PushStream function ps
let inline filter ([<InlineIfLambda>] f) ([<InlineIfLambda>] ps : _ PushStream) : _ PushStream = fun ([<InlineIfLambda>] r) ->
// ps is the previous push stream which we invoke with our receiver lambda
// Our receiver lambda checks if each received value passes filter function f
// If it does we pass the value to r, otherwise we return true to continue
// f, ps and r are lambdas that should be inlined due to InlineIfLambda
ps (fun v -> if f v then r v else true)
// Maps a PushStream using a mapping function
let inline map ([<InlineIfLambda>] f) ([<InlineIfLambda>] ps : _ PushStream) : _ PushStream = fun ([<InlineIfLambda>] r) ->
// ps is the previous push stream which we invoke with our receiver lambda
// Our receiver lambda maps each received value with map function f and
// pass the mapped value to r
// If it does we pass the value to r, otherwise we return true to continue
// f, ps and r are lambdas that should be inlined due to InlineIfLambda
ps (fun v -> r (f v))
// Folds a PushStream using a folder function f and an initial value z
let inline fold ([<InlineIfLambda>] f) z ([<InlineIfLambda>] ps : _ PushStream) =
let mutable s = z
// ps is the previous push stream which we invoke with our receiver lambda
// Our receiver lambda folds the state and value with folder function f
// Returns true to continue looping
// f and ps are lambdas that should be inlined due to InlineIfLambda
// This also means that s should not need to be a ref cell which avoids
// some memory pressure
ps (fun v -> s <- f s v; true) |> ignore
s
// It turns out that if we pipe using |> the F# compiler don't inline
// the lambdas as we like it to.
// So define a more restrictive version of |> that applies function f
// to a function v
// As both f and v are restricted to lambas we can apply InlineIfLambda
let inline (|>>) ([<InlineIfLambda>] v : _ -> _) ([<InlineIfLambda>] f : _ -> _) = f vThe previous pipeline with the PushStream definition above:
open PushStream
ofRange 0 10000
|>> map ((+) 1)
|>> filter (fun v -> (v &&& 1) = 0)
|>> map int64
|>> fold (+) 0LLooks pretty good but how does it perform?
First let's define a baseline to compare all performance against, a simple for loop that computes the same result as the pipeline above
let mutable s = 0L
for i = 0 to 10000 do
let i = i + 1
if (i &&& 1) = 0 then
s <- s + int64 i
sThen we define a bunch of benchmarks and compare them using Benchmark.NET.
open PushStream
type [<Struct>] V2 = V2 of int*int
[<MemoryDiagnoser>]
[<RyuJitX64Job>]
type PushStream6Benchmark() =
class
[<Benchmark>]
member x.Baseline() =
// The baseline performance
// We expect this to do the best
let mutable s = 0L
for i = 0 to 10000 do
let i = i + 1
if (i &&& 1) = 0 then
s <- s + int64 i
s
[<Benchmark>]
member x.Linq() =
// LINQ performance
Enumerable.Range(0,10001).Select((+) 1).Where(fun v -> (v &&& 1) = 0).Select(int64).Sum()
[<Benchmark>]
member x.Array () =
// Array performance
Array.init 10000 id
|> Array.map ((+) 1)
|> Array.filter (fun v -> (v &&& 1) = 0)
|> Array.map int64
|> Array.fold (+) 0L
[<Benchmark>]
member x.Seq () =
// Seq performance
seq { 0..10000 }
|> Seq.map ((+) 1)
|> Seq.filter (fun v -> (v &&& 1) = 0)
|> Seq.map int64
|> Seq.fold (+) 0L
[<Benchmark>]
member x.PushStream () =
// PushStream using |>
ofRange 0 10000
|> map ((+) 1)
|> filter (fun v -> (v &&& 1) = 0)
|> map int64
|> fold (+) 0L
[<Benchmark>]
member x.FasterPushStream () =
// PushStream using |>> as it turns out that
// |> prevents inlining of lambdas
ofRange 0 10000
|>> map ((+) 1)
|>> filter (fun v -> (v &&& 1) = 0)
|>> map int64
|>> fold (+) 0L
[<Benchmark>]
member x.PushStreamV2 () =
ofRange 0 10000
|> map (fun v -> V2 (v, 0))
|> map (fun (V2 (v, w)) -> V2 (v + 1, w))
|> filter (fun (V2 (v, _)) -> (v &&& 1) = 0)
|> map (fun (V2 (v, _)) -> int64 v)
|> fold (+) 0L
[<Benchmark>]
member x.FasterPushStreamV2 () =
// Mor
ofRange 0 10000
|>> map (fun v -> V2 (v, 0))
|>> map (fun (V2 (v, w)) -> V2 (v + 1, w))
|>> filter (fun (V2 (v, _)) -> (v &&& 1) = 0)
|>> map (fun (V2 (v, _)) -> int64 v)
|>> fold (+) 0L
end
BenchmarkRunner.Run<PushStream6Benchmark>() |> ignoreOn my admittedly aging machine Benchmark.NET reports these performance numbers.
BenchmarkDotNet=v0.13.1, OS=Windows 10.0.19044.1348 (21H2)
Intel Core i5-3570K CPU 3.40GHz (Ivy Bridge), 1 CPU, 4 logical and 4 physical cores
.NET SDK=6.0.100
[Host] : .NET 6.0.0 (6.0.21.52210), X64 RyuJIT DEBUG
RyuJitX64 : .NET 6.0.0 (6.0.21.52210), X64 RyuJIT
Job=RyuJitX64 Jit=RyuJit Platform=X64
| Method | Mean | Error | StdDev | Ratio | RatioSD | Gen 0 | Allocated |
|------------------- |-----------:|----------:|----------:|------:|--------:|--------:|----------:|
| Baseline | 6.807 us | 0.0617 us | 0.0577 us | 1.00 | 0.00 | - | - |
| Linq | 148.106 us | 0.5009 us | 0.4685 us | 21.76 | 0.19 | - | 400 B |
| Array | 53.630 us | 0.1744 us | 0.1631 us | 7.88 | 0.08 | 44.7388 | 141,368 B |
| Seq | 290.103 us | 0.5075 us | 0.4499 us | 42.59 | 0.34 | - | 480 B |
| PushStream | 34.214 us | 0.0966 us | 0.0904 us | 5.03 | 0.04 | - | 168 B |
| FasterPushStream | 9.011 us | 0.0231 us | 0.0216 us | 1.32 | 0.01 | - | - |
| PushStreamV2 | 151.564 us | 0.3724 us | 0.3301 us | 22.25 | 0.18 | - | 216 B |
| FasterPushStreamV2 | 9.012 us | 0.0385 us | 0.0360 us | 1.32 | 0.01 | - | - |
The imperative Baseline does the best as we expect.
Linq, Array and Seq adds significant overhead over the Baseline. This is because the lambda functions all are very cheap to make any overhead caused by the pipeline to be clearly visible.
It doesn't necessarily mean that your code would benefit of a rewrite to an imperative style over using Seq. If the lambda functions are expensive or the pipeline processing is a small part of your application using Seq is fine.
Array allocates a significant amount of memory that has to be GC:ed.
We see that PushStream does pretty good but what's real interesting is FasterPushStream where InlineIfLambda is properly applied thanks to operator |>>.
The performance of the FasterPushStream is comparable to the Baseline and it also don't allocate any memory.
The above benchmark iterated used an input range 0..10000 but what happens if we change to a shorter range 0..10:
BenchmarkDotNet=v0.13.1, OS=Windows 10.0.19044.1379 (21H2)
Intel Core i5-3570K CPU 3.40GHz (Ivy Bridge), 1 CPU, 4 logical and 4 physical cores
.NET SDK=6.0.100
[Host] : .NET 6.0.0 (6.0.21.52210), X64 RyuJIT DEBUG
RyuJitX64 : .NET 6.0.0 (6.0.21.52210), X64 RyuJIT
Job=RyuJitX64 Jit=RyuJit Platform=X64
| Method | Mean | Error | StdDev | Ratio | RatioSD | Gen 0 | Allocated |
|------------------- |-----------:|----------:|----------:|------:|--------:|-------:|----------:|
| Baseline | 8.746 ns | 0.0287 ns | 0.0269 ns | 1.00 | 0.00 | - | - |
| Linq | 290.427 ns | 0.6953 ns | 0.6164 ns | 33.22 | 0.13 | 0.1273 | 400 B |
| Array | 104.258 ns | 0.7117 ns | 0.6658 ns | 11.92 | 0.09 | 0.0764 | 240 B |
| Seq | 481.877 ns | 1.6078 ns | 1.4252 ns | 55.11 | 0.22 | 0.1526 | 480 B |
| PushStream | 74.861 ns | 0.2804 ns | 0.2623 ns | 8.56 | 0.03 | 0.0535 | 168 B |
| FasterPushStream | 10.761 ns | 0.0302 ns | 0.0267 ns | 1.23 | 0.00 | - | - |
| PushStreamV2 | 206.379 ns | 0.4882 ns | 0.4567 ns | 23.60 | 0.10 | 0.0687 | 216 B |
| FasterPushStreamV2 | 10.736 ns | 0.0175 ns | 0.0164 ns | 1.23 | 0.00 | - | - |
The FasterPushStream does even better thanks to that it doesn't need to setup a pipeline. Array memory overhead goes from clearly the biggest overhead to about average as the overhead of the pipeline created for Linq and Seq is comparable to that of the intermediate arrays created by Array.
PushStreamV2 was added to expose the cost of F# tail calls. Tail calls in F# is annotated with .tail attribute to tell the jitter that the stack frame doesn't have to be preserved.
In .NET5 this caused a significant slow down when dealing with types that don't fit in the CPU register due to the runtime eliminating the stack frame on each call. With
.NET6 PushStreamV2 does worse but not horribly so thanks to improvements in the jitter meaning a stack frame is never created and thus doesn't need to be eliminated.
What's exciting is that FasterPushStreamV2 performs just as well as FasterPushStream thanks to inlining.
See appendix for more details.
While I think it's very exciting that we can write performant data pipelines in F# there are two issues that make PushStream finicky to use.
The difference between benchmarks PushStream and FasterPushStream is that the PushStream uses |> which is the normal piping operator in F#.
When |> is used together with PushStream no inlining of lambdas happens which means increased CPU and memory overhead.
Perhaps F# should be changed to support inlining even if |> is used?
The workaround to define an operator |>> that has the InlineIfLambda attribute works but it is easy for a programmer to make mistakes as no warnings are produced by the compiler.
let inline (|>>) ([<InlineIfLambda>] v : _ -> _) ([<InlineIfLambda>] f : _ -> _) = f vmanofstick gave me important feedback to this blog post and he noted the inlining failed in the following situation
// This doesn't inline
ofArray [|0..10|] |>> fold (+) 0With a simple tweak the inlining comes back:
let vs = [|0..10|]
ofArray vs |>> fold (+) 0This happens for a couple of scenarios and it's hard to understand why the compiler wouldn't inline the first example but chose to inline the second.
This makes the PushStream performance hard to predict as no warnings are produced by the compiler.
It's possible for a programmer to verify the generated code using tools like dnspy and tweak the code until inlining is restored. It doesn't feel like the optimal experience though.
Perhaps when inlining is applied or not should be more predictable.
To me InlineIfLambda is the most exciting F#6 feature as it allow us to create abstractions with little overhead where before we had to rewrite the code to an imperative style.
This makes me wonder if the presence of inline and InlineIfLambda makes F# the best .NET language to write performant code in.
Full source code available at GitHub.
Merry Christmas
Mårten
One drawback with PushStream is that it doesn't can't implement seq<_> as a producer when it starts running it runs to completion, there's no way to yield the producer.
An alternative is PumpStream. A PumpStream returns a function that the consumer calls each time it wants a value, the pump operation might yield no value (as filter operations drops values) so several pumping operations might be needed to produce a value.
A simple version of PumpStream could look like this:
// TODO: Support disposing sources
type 'T PumpStream = ('T -> bool)->(unit -> bool)
module PumpStream =
open System
open System.Collections.Generic
// PumpStream of ints in range b..e
let inline ofRange b e : int PumpStream = fun ([<InlineIfLambda>] r) ->
let mutable i = b
fun () ->
if i <= e && r i then
i <- i + 1
true
else
false
// Filters a PumpStream using a filter function
let inline filter ([<InlineIfLambda>] f) ([<InlineIfLambda>] ps : _ PumpStream) : _ PumpStream = fun ([<InlineIfLambda>] r) ->
ps (fun v -> if f v then r v else true)
// Maps a PumpStream using a mapping function
let inline map ([<InlineIfLambda>] f) ([<InlineIfLambda>] ps : _ PumpStream) : _ PumpStream = fun ([<InlineIfLambda>] r) ->
ps (fun v -> r (f v))
// Folds a PumpStream using a folder function f and an initial value z
let inline fold ([<InlineIfLambda>] f) z ([<InlineIfLambda>] ps : _ PumpStream) =
let mutable s = z
let p = ps (fun v -> s <- f s v; true)
while p () do ()
s
// Implements seq<_> over a PumpStream
let inline toSeq ([<InlineIfLambda>] ps : 'T PumpStream) =
{ new IEnumerable<'T> with
override x.GetEnumerator () : IEnumerator<'T> =
let mutable current = ValueNone
let p = ps (fun v -> current <- ValueSome v; true)
{ new IEnumerator<'T> with
// TODO: Implement Dispose
member x.Dispose () = ()
member x.Reset () = raise (NotSupportedException ())
member x.Current : 'T = current.Value
member x.Current : obj = current.Value
member x.MoveNext () =
current <- ValueNone
while p () && current.IsNone do ()
current.IsSome
}
override x.GetEnumerator () : Collections.IEnumerator =
x.GetEnumerator ()
}
// It turns out that if we pipe using |> the F# compiler don't inlines
// the lambdas as we like it to
// So define a more restrictive version of |> that applies function f to a function v
// As both f and v are restibted to lambas we can apply InlineIfLambda
let inline (|>>) ([<InlineIfLambda>] v : _ -> _) ([<InlineIfLambda>] f : _ -> _) = f vThe PumpStream is more complex than the PushStream so we expect it to perform worse but how much worse?
| Method | Job | Mean | Error | StdDev | Ratio | RatioSD | Gen 0 | Allocated |
|------------------- |---- |-----------:|----------:|----------:|------:|--------:|--------:|----------:|
| Baseline | PGO | 6.666 μs | 0.1036 μs | 0.0969 μs | 1.00 | 0.00 | - | - |
| Linq | PGO | 88.306 μs | 1.3255 μs | 1.2398 μs | 13.25 | 0.25 | 0.1221 | 400 B |
| Array | PGO | 41.591 μs | 0.1992 μs | 0.1664 μs | 6.25 | 0.09 | 44.7388 | 141,368 B |
| Seq | PGO | 142.978 μs | 0.2711 μs | 0.2403 μs | 21.48 | 0.32 | - | 480 B |
| FasterPushStream | PGO | 8.786 μs | 0.0531 μs | 0.0497 μs | 1.32 | 0.02 | - | - |
| FasterPushStreamV2 | PGO | 8.776 μs | 0.0387 μs | 0.0362 μs | 1.32 | 0.02 | - | - |
| FasterPumpStream | PGO | 17.901 μs | 0.0537 μs | 0.0503 μs | 2.69 | 0.04 | - | 80 B |
| FasterPumpStreamV2 | PGO | 17.778 μs | 0.0545 μs | 0.0510 μs | 2.67 | 0.04 | - | 80 B |
This run uses the new .NET6 feature of Profile Guided Optimizations, this does improve LINQ and Seq performance quite significantly but it also shows that PumpStream while slower than PushStream only adds about 3x overhead over the baseline + some memory overhead compared to PushStream 1.5x overhead over the baseline.
Using dnSpy we can decompile the compiled IL code into C# to learn what's going on in more details
public long Baseline()
{
long s = 0L;
for (int i = 0; i < 10001; i++)
{
int j = i + 1;
if ((j & 1) == 0)
{
s += (long)j;
}
}
return s;
}The baseline not very surprisingly becomes a quite efficient loop.
[Benchmark]
public long FasterPushStream()
{
long num = 0L;
int num2 = 0;
for (;;)
{
bool flag;
if (num2 <= 10000)
{
int num3 = num2;
int num4 = 1 + num3;
if ((num4 & 1) == 0)
{
long num5 = (long)num4;
num += num5;
flag = true;
}
else
{
flag = true;
}
}
else
{
flag = false;
}
if (!flag)
{
break;
}
num2++;
}
bool flag2 = num2 > 10000;
return num;
}While a bit more code one can see that thanks to inline and InlineIfLambda everything is inlined into something that looks like decently efficient code.
We can also spot a reason why FasterPushStream does a bit worse than Baseline as the PushStream includes a short-cutting mechanism that allows the receiver to say it doesn't want to receive more values. This is to allow implementing tryHead and similar operations efficiently.
public long PushStream()
{
FSharpFunc<FSharpFunc<int, bool>, bool> _instance = Program.PushStream@55.@_instance;
FSharpFunc<FSharpFunc<int, bool>, bool> arg = new Program.PushStream@56-2(@_instance);
FSharpFunc<FSharpFunc<long, bool>, bool> fsharpFunc = new Program.PushStream@57-4(arg);
FSharpRef<long> fsharpRef = new FSharpRef<long>(0L);
bool flag = fsharpFunc.Invoke(new Program.PushStream@58-6(fsharpRef));
return fsharpRef.contents;
}Using |> F# don't inline the lambdas and a pipeline is set up. This leads to objects being created and virtual calls for each step in the pipeline.
The pipeline does surprisingly well but one big problem with this approach is that it might need to fallback to slow tail calls gives a significant performance drop.
There are work-arounds to prevent .tail attribute from being emitted but that hurt performance when a fast tail call could be used.
Inlining solves this issue as the tail calls are elimiated.
To learn more about what's actually going we can disassemble the jitted code.
The baseline disassembled:
.loop:
; Increment loop variable (smart enough to pre increment + 1)
inc edx
mov ecx,edx
; filter (fun (V2 (v, _)) -> (v &&& 1) = 0)
test cl,1
jne .next
; map (fun (V2 (v, _)) -> int64 v)
movsxd rcx,ecx
add rax,rcx
.next
; Increment loop variable
cmp edx,2711h
jl .loopHere the jitter was smart enough to pre increment with 1 to avoid incrementing by 1 each loop. In addition, checks the loop condition at the end saves a jmp.
Let's look at FasterPushStreamV2:
.loop:
; Are we done?
cmp edx,2710h
jg .we_are_done
; (fun (V2 (v, w)) -> V2 (v + 1, w))
lea ecx,[rdx+1]
; filter (fun (V2 (v, _)) -> (v &&& 1) = 0)
test cl,1
jne .next
; map (fun (V2 (v, _)) -> int64 v)
movsxd rcx,ecx
; fold (+) 0L
add rax,rcx
.next
; Increment loop variable
inc edx
jmp .loopThis looks pretty amazing. The V2 struct and all virtual calls are completely gone.
The jitter also eliminated the short cutting condition as the producer is always fully consumed.
The extra overhead seems to come from the pre-increment optimization wasn't applied here and that the end-of-the-loop condition is done differently.
Still not bad.
By looking at the IL code one can see that the F# compiler has added a .tail attribute on the calls to the receiver.
; This tells the jitter that next call is a tail call
IL_000C: tail.
; Tail call virtual
IL_000E: callvirt instance !1 class [FSharp.Core]Microsoft.FSharp.Core.FSharpFunc`2<class [FSharp.Core]Microsoft.FSharp.Core.FSharpFunc`2<int32, bool>, bool>::Invoke(!0)
IL_0013: retWhen invoking the next receiver in the PushStream the F# compiler emits tail. attribute.
This leads to the following jitted code:
; ofRange 0 10000
.loop:
; Are we done?
cmp edi,2710h
jg .we_are_done
; Setup virtual call to map receiver
mov rcx,rsi
mov edx,edi
mov rax,qword ptr [rsi]
mov rax,qword ptr [rax+40h]
; Call the map receiver (no tail call)
call qword ptr [rax+20h]
; Does the receiver think we should stop?
test eax,eax
je .we_are_done
; Increment loop variable
inc edi
jmp .loop
; map (fun v -> V2 (v, 0))
; Save value of rax
push rax
; Load address to map receiver
mov rcx,qword ptr [rcx+8]
; Clear eax
xor eax,eax
; Save V2 on stack
mov dword ptr [rsp],edx
mov dword ptr [rsp+4],eax
mov rdx,qword ptr [rsp]
; Setup virtual call to map receiver
mov rax,qword ptr [rcx]
mov rax,qword ptr [rax+40h]
mov rax,qword ptr [rax+20h]
; Restore stack
add rsp,8
; tail call to map receiver
jmp rax
; (fun (V2 (v, w)) -> V2 (v + 1, w))
; Save value of rax
push rax
; Save rdx V2 (wonder why it stores a 64bit word?)
mov qword ptr [rsp+18h],rdx
; Load address to filter receiver
mov rcx,qword ptr [rcx+8]
; Loads V2 (v, _)
mov edx,dword ptr [rsp+18h]
; v + 1
inc edx
; Load V2 (_, w)
mov eax,dword ptr [rsp+1Ch]
; It seems the whole round trip to the stack for V2 was unnecessary
; Store V2 on stack
mov dword ptr [rsp],edx
mov dword ptr [rsp+4],eax
mov rdx,qword ptr [rsp]
; Setup virtual call to map receiver
mov rax,qword ptr [rcx]
mov rax,qword ptr [rax+40h]
mov rax,qword ptr [rax+20h]
add rsp,8
; tail call to filter receiver
jmp rax
; filter (fun (V2 (v, _)) -> (v &&& 1) = 0)
mov qword ptr [rsp+10h],rdx
; Test to see V2(v, _) the number is odd (V2 is on the stack)
test byte ptr [rsp+10h],1
jne .bail_out
; No it's even
; Load address to filter receiver
mov rcx,qword ptr [rcx+8]
mov rdx,qword ptr [rsp+10h]
; Setup virtual call to map receiver
mov rax,qword ptr [rcx]
mov rax,qword ptr [rax+40h]
mov rax,qword ptr [rax+20h]
; tail call to map receiver
jmp rax
.bail_out:
; No it was odd
; Set eax to 1 (true) to continue looping
mov eax,1
; Return to ofRange loop
ret
; map (fun (V2 (v, _)) -> int64 v)
mov qword ptr [rsp+10h],rdx
; Load address to fold receiver
mov rcx,qword ptr [rcx+8]
; Load V2(v,_)
mov edx,dword ptr [rsp+10h]
; Extend to 64bit
movsxd rdx,edx
; Setup virtual call to fold receiver
mov rax,qword ptr [rcx]
mov rax,qword ptr [rax+40h]
mov rax,qword ptr [rax+20h]
; tail call to fold receiver
jmp rax
; fold (+) 0L
; Load fold state
mov rax,qword ptr [rcx+8]
; Move state?
mov rdx,rax
; Add V2(v,_) to state
add rdx,qword ptr [rax+8]
; Save state
mov qword ptr [rcx+8],rdx
; Set eax to 1 (true) to continue looping
mov eax,1
; Return to ofRange loop
retLot more jitted code which explains the reduced of performance, I am actually surprised it performs as well as it should but I suppose CPUs recognizes common patterns for making virtual calls and optimize for that.
What's great though is that we see that tail calls are applied jmp and that they are much more effiecient than in .NET5 that did tail call through a helper function.
Slower than when inlined but still improvments has been made to jitter.
This is some pretty amazing content here!
Thanks a TON! ❤️