mthierry

name	reviewer
description	Reviews code changes against the original plan or request to verify the implementation actually matches what was asked for. Use proactively after any significant code change, or when explicitly invoked (e.g. "use the reviewer agent to check this against the spec").
tools	Read, Glob, Grep
model	sonnet

You are a spec-compliance reviewer. Your job is NOT general code quality — it is to verify that what was implemented actually matches what was asked for.

You have read-only access. You never edit files. You report findings back to the main agent.

mthierry

with rbenv & ruby-build

a) Prereq 1. Install rbenv (https://github.com/rbenv/rbenv)

cd
git clone https://github.com/rbenv/rbenv.git ~/.rbenv
echo 'export PATH="$HOME/.rbenv/bin:$PATH"' >> ~/.bashrc
echo 'eval "$(rbenv init -)"' >> ~/.bashrc
exec $SHELL

mthierry

diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index 7f42565ce53e..eada3dc145b6 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -915,6 +915,8 @@ static void intel_lrc_irq_handler(unsigned long data)
 			/* After the final element, the hw should be idle */
 			GEM_BUG_ON(port_count(port) == 0 &&
 				   !(status & GEN8_CTX_STATUS_ACTIVE_IDLE));
+			if (status & GEN8_CTX_STATUS_ACTIVE_IDLE)
+				mdelay(2);

mthierry

commit 8cc7a88e3430e3dbc0a5c873c467ee9fed729cfd
Author: Akash Goel <akash.goel@intel.com>
Date:   Mon Dec 28 13:56:18 2015 +0530

    drm/i915: Support to enable TRTT on GEN9
    
    Gen9 has an additional address translation hardware support in form of
    Tiled Resource Translation Table (TR-TT) which provides an extra level
    of abstraction over PPGTT.
    This is useful for mapping Sparse/Tiled texture resources.

mthierry

	
                            .,,cc,,,.
                        ,c$$$$$$$$$$$$cc,
                     ,c$$$$$$$$$$??""??$?? ..
                  ,z$$$$$$$$$$$P xdMMbx  nMMMMMb
                 r")$$$$??$$$$" dMMMMMMb "MMMMMMb
               r",d$$$$$>;$$$$ dMMMMMMMMb MMMMMMM.
              d'z$$$$$$$>'"""" 4MMMMMMMMM MMMMMMM>
             d'z$$$$$$$$h $$$$r`MMMMMMMMM "MMMMMM
             P $$$$$$$$$$.`$$$$.'"MMMMMP',c,"""'..

mthierry

#!/bin/bash

result=$(curl -sf --data-binary @${1:--} https://hastebin.com/documents) || {
	echo "ERROR: failed to post document" >&2
	exit 1
}

key=$(jq -r .key <<< $result)

echo "https://hastebin.com/${key}"

mthierry

diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
index c697a08b8644..8c0f3ce3b2f8 100644
--- a/drivers/gpu/drm/i915/intel_uncore.c
+++ b/drivers/gpu/drm/i915/intel_uncore.c
@@ -815,6 +815,7 @@ unclaimed_reg_debug(struct drm_i915_private *dev_priv,
 	if (likely(!i915.mmio_debug))
 		return;
 
+	DRM_INFO("reading reg = 0x%x\n", reg.reg);
 	__unclaimed_reg_debug(dev_priv, reg, read, before);

mthierry

#set -x
#pkg=$(aapt dump badging $1|awk -F" " '/package/ {print $2}'|awk -F"'" '/name=/ {print $2}')
#act=$(aapt dump badging $1|awk -F" " '/launchable-activity/ {print $2}'|awk -F"'" '/name=/ {print $2}')
#adb shell am start -n $pkg/$act

#package=`aapt dump badging $* | grep package | awk '{print $2}' | sed s/name=//g | sed s/\'//g`
#activity=`aapt dump badging $* | grep Activity | awk '{print $2}' | sed s/name=//g | sed s/\'//g`
#echo
package=com.android.camera2
activity=com.android.camera.CameraActivity

mthierry

diff --git a/drivers/gpu/drm/drm_fops.c b/drivers/gpu/drm/drm_fops.c
index 036cd27..8c568c7 100644
--- a/drivers/gpu/drm/drm_fops.c
+++ b/drivers/gpu/drm/drm_fops.c
@@ -44,6 +44,7 @@
 
 /* from BKL pushdown */
 DEFINE_MUTEX(drm_global_mutex);
+EXPORT_SYMBOL(drm_global_mutex);
 

mthierry

diff --git a/drivers/gpu/drm/i915/i915_guc_submission.c b/drivers/gpu/drm/i915/i915_guc_submission.c
index 7935959..0731950 100644
--- a/drivers/gpu/drm/i915/i915_guc_submission.c
+++ b/drivers/gpu/drm/i915/i915_guc_submission.c
@@ -969,10 +969,16 @@ static void guc_move_to_next_buf(struct intel_guc *guc)
 	smp_wmb();
 
 	/* All data has been written, so now move the offset of sub buffer. */
+#if IS_ENABLED(CONFIG_DEBUG_PREEMPT)
+	preempt_disable();