nataliemarleny

#!/usr/bin/env bash
set -eu -o pipefail

markdown_dir="${1:-markdown}"
html_dir="${2:-html}"
MARKED_EXEC="${MARKED_EXEC:-yarn exec marked}"

sanitise() {
  cat | sed 's#\.md#.html#g'
}

nataliemarleny

Suggestion / Tiny Bug:

• A description of the problem you're trying to solve:

./.vscode > tasks.json contains deprecated API tasks.identifier.

Reference: microsoft/vscode#57946 Further discussion see thread containing: microsoft/vscode#57707 (comment) Schema for tasks.json: https://code.visualstudio.com/docs/editor/tasks-appendix

nataliemarleny

▲

Basically what Link currently does is detect if the direct child is an . If it is it'll React.cloneElement and add on the href as a property. Now if we add a warning for not It's hard to detect, because e.g. styled-components would wrap the with styles, and there's a bunch of other cases like that.

So the way we thought about fixing this is through not requiring nexting the and making always add in the . However, that'd be a super heavy breaking change which would affect everything - user layout, styling, accessibility.

The reason that they don’t have that specific check is that someone could take the a tag and do styled components, and that changes the markup from just an a tag, to being a component. If that you then detect that thing to do a warning, it will then not work.

However we’ve talked about the new use-link thing doesn’t return a link component it returns an a tag, so that would always be a link using an a tag however we can’t do use-link so I’m not sure if we can c

nataliemarleny

// Reduced
const obj1 = {
  fun1() {}
}

const obj1 = {
  fun1: () => {}
}

// this

nataliemarleny

const sum = require('./sum');

test('adds 1 + 2 to equal 3', () => {
  expect(sum(1, 2)).toBe(3);
});

nataliemarleny

function sum(a, b) {
  return a + b;
}
module.exports = sum;

nataliemarleny

{
  "scripts": {
    "test": "jest"
  }
}

nataliemarleny

{
  "scripts": {
    "dev": "next",
    "build": "next build",
    "start": "next start"
  }
}

nataliemarleny

const Main = () => (
  <div>Main page!</div>
);

export default Main;

nataliemarleny

# JavaScript
node_modules
.next

# Mac
.DS_Store