Bumping Nokogiri to 1.11.5, caused our tests around HTML tables to start failing with ERROR: Recursion limit exceeded
. The change that caused this is in commit [#9fcb7d][1] (see also: [the full set of changes][2]), where the recursion limit is restricted to 500 (see: [libxml2 commit][3]), which is how it started happening with this Nokogiri update.
In investigating what was causing this to recur, it seems like we don't need all of capybara-table
, as [enough is already included in Capybara itself][4].
I did consider just dropping the dependency, but the Matcher/Renderer classes are key to the usability of our tests — I even tried not using them but trying to factor out the dependency was a horrible experience.
My next step would be to try and switch the Capybara selector that CapybaraTable::RspecMatchers
uses to the ones already in Capybara: [table.rb
][5] and [table_row.rb
][6]. This might be as simple as vendering the RspecMatchers.rb
file into the project and seein