Skip to content

Instantly share code, notes, and snippets.

@nikic

nikic/push.json Secret

Created March 29, 2021 14:10
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save nikic/ce743798df197f45a6ab3e39042641b9 to your computer and use it in GitHub Desktop.
Save nikic/ce743798df197f45a6ab3e39042641b9 to your computer and use it in GitHub Desktop.
"commits": [
{
"id": "b95b553489c9fa0660932792edc666a2e511d1d2",
"tree_id": "c6426967b7941c486d8a6469b512a0cd7df880d5",
"distinct": false,
"message": "Remove zero size special case for copy_to_stream\n\nThis doesn't seem to serve a purpose anymore. Stats are expensive,\nso doing an unnecessary stat just to short-circuit the zero size\ncase is rather dubious. It can also break with stream wrappers\nthat return inaccurate sizes (symfony/symfony#40574) and probably\ncan also break with stream filters.\n\nDrop the special case and adjust code to make it more obvious that\nit will still be handled correctly.\n\nCloses GH-6807.",
"timestamp": "2021-03-29T15:21:59+02:00",
"url": "https://github.com/php/php-src/commit/b95b553489c9fa0660932792edc666a2e511d1d2",
"author": {
"name": "Nikita Popov",
"email": "nikita.ppv@gmail.com",
"username": "nikic"
},
"committer": {
"name": "Nikita Popov",
"email": "nikita.ppv@gmail.com",
"username": "nikic"
},
"added": [
"ext/standard/tests/file/stream_copy_to_stream_empty.phpt"
],
"removed": [
],
"modified": [
"main/streams/streams.c"
]
},
{
"id": "202a701a4e626d1aeef1fda32cd56af3931db04e",
"tree_id": "3c155a6eab70bf711782fe05e1b9163033d9c504",
"distinct": true,
"message": "Merge branch 'PHP-8.0'\n\n* PHP-8.0:\n Remove zero size special case for copy_to_stream",
"timestamp": "2021-03-29T15:22:50+02:00",
"url": "https://github.com/php/php-src/commit/202a701a4e626d1aeef1fda32cd56af3931db04e",
"author": {
"name": "Nikita Popov",
"email": "nikita.ppv@gmail.com",
"username": "nikic"
},
"committer": {
"name": "Nikita Popov",
"email": "nikita.ppv@gmail.com",
"username": "nikic"
},
"added": [
"ext/standard/tests/file/stream_copy_to_stream_empty.phpt"
],
"removed": [
],
"modified": [
"main/streams/streams.c"
]
}
],
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment