This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A library that uses the Postmark-Server-Token: | |
- It should get delivery stats (to parse them by Type and detect whether or not iterate over bounces) | |
- It should get bounces (for those types whose count is greater than zero) | |
- It should get single bounce to parse details | |
- It should have logic to (maybe?) have external input to decide to attempt re-send (activate) | |
# I like using HTTParty but Typhoeus could work very well here. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client::PortalController analysis. | |
What does it do? | |
It seems to take care of the requests related to proposals. It has an action that takes care of both showing and previewing a proposal (the type of viewing gets chosen in #info action. It also has #index but the way the controller is implemented doesn't seemt to be RESTful (not a resource in the routes file). | |
I can see there is logic enable via includes that could enable the 'presenter' design pattern, and in the #canvas action, I can see a bit of the 'template' design pattern, and also I can see there are calls to Amazon S3 service; also the proposals states and acceptance are handled by this controller as well as comments related to a single proposal. I noticed mailer logic for several actions: acceptance, set_status and show (although I can't see why ClientEmailer.deliver_proposal_accepted(proposal) is called in two different actions. | |
What I like about it. |
NewerOlder