Created
December 22, 2018 01:56
-
-
Save pudly/d6cf7e8fce75b295ae035fa50461d07e to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<midzer> meaning we can't derive slug from title in all cases | |
[14:44:03] <midzer> or we lose those URLs | |
[14:44:05] <drej> so we check if .json has slug="" something, if so we use that, if not we derrive it from title | |
[14:44:07] <drej> derive * | |
[14:44:34] <midzer> yeah, i can capture those cases i think | |
[14:44:37] <drej> ok cool | |
[14:44:43] <midzer> we can do it in the end | |
[14:44:44] <drej> that can be for tomorrow, i know its late | |
[14:44:52] <midzer> i open a card so we dont forget | |
[14:44:55] <drej> ok | |
[14:45:08] <midzer> new PR is up :) | |
[14:48:46] <drej> cool, i broke my local instance hah, i gotta reboot | |
[14:48:48] <drej> brb | |
[14:49:02] <drej> then i have to take my little guy to the grandparents place so i'll be out for another hour | |
[14:49:04] <drej> i likely wont see you again tonight | |
[14:49:12] <drej> thanks for all the hard work again, i'll get some more tickets up on trello for tomorrow | |
[14:53:32] | |
[14:53:32] * Loaded log from Fri Dec 21 14:49:12 2018 | |
[14:53:32] | |
[14:53:43] <drej> i just pulled the PR, looks good so far | |
[14:54:54] <drej> gotta run, see you in the morning | |
[14:54:55] <midzer> okay, i play around some more with trello and then I'm afk, too | |
[14:55:14] <midzer> cya around tomorrow | |
[14:55:25] <midzer> we have ~50% of data converted btw | |
[14:57:39] <drej> for articles yes | |
[14:57:46] <drej> there's still all the people, companies, authors, videos :) | |
[14:58:18] <drej> companies and people have completely different data types than articles | |
[14:58:20] <drej> so do authors | |
[15:01:56] <midzer> yeah, probably not 50% done in general, but we're on a good way | |
[15:02:56] <midzer> dont forget to put cloudinary "slug" in https://trello.com/c/eIgdnAn3/20-article-images so I can extend parser tomorrow | |
[15:03:17] <midzer> didnt check example images yet | |
[15:04:31] <midzer> https://res.cloudinary.com/schmopera/image/upload/v1545409169/media/2018/12/unnamed.jpg from fixings post | |
[15:09:02] <midzer> i dont know what to replace | |
[15:09:31] <midzer> in gist sample it is "url": "/webhook-uploads/1430275669426/Isabel-1024x640.png", | |
[16:21:42] <drej> okay, i'll capture the image location on cloudinary and an example | |
[16:22:25] <drej> it'll just be /webhook-uploads/1430275669426/Isabel-1024x640.png --> https://res.cloudinary.com/schmopera/image/upload/v1545409169/media/webhook-uploads/1430275669426/Isabel-1024x640.png | |
[16:22:36] <drej> but we also have to parse all the content, because there are inline images, not just the ones with attributes | |
[16:22:54] <drej> so the actual article content has references to images that are also /webhook-uploads/something which will also have to be replaced | |
[16:23:00] <drej> i'll capture all that in the ticket | |
[16:31:51] * Disconnected (No such device or address) | |
[20:27:11] -SaslServ- drej!~jedimind@unaffiliated/jedimind has just authenticated as you (jedimind) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment