Implementations of https://www.interviewcake.com/question/largest-stack ’s official answer in Ruby – a buggy, wrong implementation of a stack with #get_largest

conversion_with_small_error_fixed.rb

class MaxStack
	attr_reader :stack, :largests_stack # for debugging
	
	def initialize
		@stack = []
		@largests_stack = []
	end
	
	def push(item)
		@stack.push(item)
		if @largests_stack.empty? || item >= @largests_stack.last
			@largests_stack.push(item)
		end
		item
		
		#@largest = [@largest, item].max
	end
	
	def pop()
		item = @stack.pop
		if item == @largests_stack.last
			@largests_stack.pop
		end
		item
	end
	
	def get_largest
		@largests_stack.last
		
		#if @stack.empty? throw "no values"
		#@stack.max
	end
end

straight_conversion.rb

class MaxStack
	attr_reader :stack, :largests_stack # for debugging
	
	def initialize
		@stack = []
		@largests_stack = []
	end
	
	def push(item)
		@stack.push(item)
		if item >= @largests_stack.last
			@largests_stack.push(item)
		end
		item
		
		#@largest = [@largest, item].max
	end
	
	def pop()
		item = @stack.pop
		if item == @largests_stack.last
			@largests_stack.pop
		end
		item
	end
	
	def get_largest
		@largests_stack.last
		
		#if @stack.empty? throw "no values"
		#@stack.max
	end
end