Skip to content

Instantly share code, notes, and snippets.

@rzarzynski

rzarzynski/bug-25146.md Secret

Last active August 21, 2018 19:56
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save rzarzynski/24a753176f7cf2d2c1fc173d8da763dc to your computer and use it in GitHub Desktop.
Save rzarzynski/24a753176f7cf2d2c1fc173d8da763dc to your computer and use it in GitHub Desktop.
Download ZIP
Raw
bug-25146.md

Investigation of the mimic to master upgrade issue

CustomTag == 0x03 in RocksDB

Assigment of the 0x03 value of CustomTag depending on Ceph and RocksDB versions:

Ceph branch CustomTag == 0x03 Ceph commit ID rocksdb commit ID
mimic kDeletedLogNumberHack eaee6d3beab3429232ceb188377a3f94e844fca7 f4a857da0b720691effc524469f6db895ad00d8e
master 0425 NONE e68d13339ee96f62fd724067ca78a02dc0e94e03 b181f1714a4baecaf7dff4c8417b20f5e6a41585
master 0815 kMinLogNumberToKeepHack 760e4718dbf55003f4bb67ada0b5a38954a214dc bc7e8d472e7d37a33f3f45dec393769011ec1e08

The history

  1. PR facebook/rocksdb#3488 introduced the change.
  2. PR facebook/rocksdb#3762 reverted it.
  3. PR facebook/rocksdb#3765 reintroduced a fixed (but not compliant at the decoding level!) version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment