Skip to content

Instantly share code, notes, and snippets.

@spetrunia
Created April 4, 2023 11:12
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save spetrunia/ec114849290860260772b6350bf25e54 to your computer and use it in GitHub Desktop.
Save spetrunia/ec114849290860260772b6350bf25e54 to your computer and use it in GitHub Desktop.
diff -urp 10.5-review2/sql/sql_select.cc 10.5-review2-cl/sql/sql_select.cc
--- 10.5-review2/sql/sql_select.cc 2023-04-04 12:32:42.636312847 +0300
+++ 10.5-review2-cl/sql/sql_select.cc 2023-04-04 13:11:28.732023482 +0300
@@ -26998,7 +26998,7 @@ void inline JOIN::clear_sum_funcs()
/*
Prepare for returning 'empty row' when there is no matching row.
- - Mark all tables with mark_as_null_with()
+ - Mark all tables with mark_as_null_row()
- Make a copy of of all simple SELECT items
- Reset all sum functions to NULL or 0.
*/
diff -urp 10.5-review2/sql/table.h 10.5-review2-cl/sql/table.h
--- 10.5-review2/sql/table.h 2023-04-04 12:32:42.636312847 +0300
+++ 10.5-review2-cl/sql/table.h 2023-04-04 13:10:41.206460223 +0300
@@ -3307,7 +3307,7 @@ inline void mark_as_null_row(TABLE *tabl
}
/*
- Restore table to state after mark_as_null_row().
+ Restore table to state before mark_as_null_row() call.
This assumes that the caller has restored table->null_flags,
as is done in unclear_tables().
*/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment