Skip to content

Instantly share code, notes, and snippets.

@staktrace
Created April 8, 2019 20:58
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save staktrace/100950aa7d14f4d540f1cd1fa6f3de13 to your computer and use it in GitHub Desktop.
Save staktrace/100950aa7d14f4d540f1cd1fa6f3de13 to your computer and use it in GitHub Desktop.
diff --git a/layout/generic/nsTextFrame.cpp b/layout/generic/nsTextFrame.cpp
index 5dac48949bbe..13a96eb805dd 100644
--- a/layout/generic/nsTextFrame.cpp
+++ b/layout/generic/nsTextFrame.cpp
@@ -5671,19 +5671,19 @@ void nsTextFrame::UnionAdditionalOverflow(nsPresContext* aPresContext,
// Inflate rect by stroke-width/2; we add an extra pixel to allow for
// antialiasing, rounding errors, etc.
nsRect strokeRect = *aVisualOverflowRect;
strokeRect.Inflate(textStrokeWidth / 2 + appUnitsPerDevUnit);
aVisualOverflowRect->UnionRect(*aVisualOverflowRect, strokeRect);
}
// Text-shadow overflows
- nsRect shadowRect =
- nsLayoutUtils::GetTextShadowRectsUnion(*aVisualOverflowRect, this);
- aVisualOverflowRect->UnionRect(*aVisualOverflowRect, shadowRect);
+ //nsRect shadowRect =
+ // nsLayoutUtils::GetTextShadowRectsUnion(*aVisualOverflowRect, this);
+ //aVisualOverflowRect->UnionRect(*aVisualOverflowRect, shadowRect);
// When this frame is not selected, the text-decoration area must be in
// frame bounds.
if (!IsSelected() ||
!CombineSelectionUnderlineRect(aPresContext, *aVisualOverflowRect))
return;
AddStateBits(TEXT_SELECTION_UNDERLINE_OVERFLOWED);
}
@@ -6121,17 +6121,17 @@ void nsTextFrame::PaintOneShadow(const PaintShadowParams& aParams,
nscolor shadowColor =
aShadowDetails->mColor.CalcColor(aParams.foregroundColor);
if (auto* textDrawer = aParams.context->GetTextDrawer()) {
wr::Shadow wrShadow;
// Gecko already inflates the bounding rect of text shadows,
// so tell WR not to inflate again.
- wrShadow.should_inflate = false;
+ wrShadow.should_inflate = true;
wrShadow.offset = {
PresContext()->AppUnitsToFloatDevPixels(aShadowDetails->mXOffset),
PresContext()->AppUnitsToFloatDevPixels(aShadowDetails->mYOffset)};
wrShadow.blur_radius = PresContext()->AppUnitsToFloatDevPixels(blurRadius);
wrShadow.color = wr::ToColorF(ToDeviceColor(shadowColor));
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment