Remove empty tabs in the SilverStripe CMS

silverstripe-remove-empty-tabs.php

/**
 * Recurse through tabs and remove any with no child fields
 *
 * The way SilverStripe's field scaffolding works can leave empty tabs around after
 * fields are moved or removed by the slices module.
 *
 * @param FieldList $fields
 * @return FieldList
 */
protected function removeEmptyTabs(FieldList $fields)
{
    foreach ($fields as $field) {
        if ($field instanceof TabSet) {
            $this->removeEmptyTabs($field->Tabs());
        }

        if ($field instanceof Tab && $field->Fields()->count() == 0) {
            $fields->remove($field);
        }
    }

    return $fields;
}

That cant be working, method call in line 14 uses 2 parameters, but method signature uses 1 parameter

@lpostiglione it's legal in PHP to pass more arguments than a function accepts - this code works (at least in SS3), I just hadn't noticed that extra junk argument hanging around. Will fix now, thanks.