Created
March 4, 2013 21:08
-
-
Save tenderlove/5085677 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diff --git a/activesupport/lib/active_support/core_ext/class/attribute.rb b/activesupport/lib/active_support/core_ext/class/attribute.rb | |
index 5d8d09a..6417703 100644 | |
--- a/activesupport/lib/active_support/core_ext/class/attribute.rb | |
+++ b/activesupport/lib/active_support/core_ext/class/attribute.rb | |
@@ -77,38 +77,41 @@ class Class | |
# may be used in a performance sensitive context therefore the overhead that | |
# define_method introduces may become significant. | |
attrs.each do |name| | |
- class_eval <<-RUBY, __FILE__, __LINE__ + 1 | |
- def self.#{name}() nil end | |
- def self.#{name}?() !!#{name} end | |
+ define_singleton_method(name) { nil } | |
+ define_singleton_method("#{name}?") { !!public_send(name) } | |
- def self.#{name}=(val) | |
- singleton_class.class_eval do | |
- remove_possible_method(:#{name}) | |
- define_method(:#{name}) { val } | |
- end | |
+ define_singleton_method("#{name}=") do |val| | |
+ singleton_class.class_eval do | |
+ remove_possible_method(name) | |
+ define_method(name) { val } | |
+ end | |
- if singleton_class? | |
- class_eval do | |
- remove_possible_method(:#{name}) | |
- def #{name} | |
- defined?(@#{name}) ? @#{name} : singleton_class.#{name} | |
+ if singleton_class? | |
+ class_eval do | |
+ remove_possible_method(name) | |
+ define_method(name) do | |
+ if instance_variable_defined?("@#{name}") | |
+ instance_variable_get "@#{name}" | |
+ else | |
+ singleton_class.send name | |
end | |
end | |
end | |
- val | |
end | |
+ val | |
+ end | |
- if instance_reader | |
- remove_possible_method :#{name} | |
- def #{name} | |
- defined?(@#{name}) ? @#{name} : self.class.#{name} | |
- end | |
- | |
- def #{name}? | |
- !!#{name} | |
+ if instance_reader | |
+ remove_possible_method name | |
+ define_method(name) do | |
+ if instance_variable_defined?("@#{name}") | |
+ instance_variable_get "@#{name}" | |
+ else | |
+ self.class.send name | |
end | |
end | |
- RUBY | |
+ define_method("#{name}?") { !!public_send(name) } | |
+ end | |
attr_writer name if instance_writer | |
end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment